From: Yang Zhong <yang.zhong@intel.com>
To: qemu-devel@nongnu.org
Cc: xiaoguangrong.eric@gmail.com, ehabkost@redhat.com,
alex.williamson@redhat.com, pbonzini@redhat.com,
anthony.xu@intel.com, yang.zhong@intel.com
Subject: [Qemu-devel] [PATCH 2/2] nvdimm: Add "nopin" for related documents
Date: Mon, 16 Oct 2017 16:56:23 +0800 [thread overview]
Message-ID: <1508144183-30844-3-git-send-email-yang.zhong@intel.com> (raw)
In-Reply-To: <1508144183-30844-1-git-send-email-yang.zhong@intel.com>
Added the "nopin" related changes in nvdimm.txt and
qemu-options.hx.
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
---
docs/nvdimm.txt | 10 ++++++++--
qemu-options.hx | 6 +++++-
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
index 2d9f8c0..41ac1c2 100644
--- a/docs/nvdimm.txt
+++ b/docs/nvdimm.txt
@@ -17,7 +17,7 @@ following command line options:
-machine pc,nvdimm
-m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
- -object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE
+ -object memory-backend-file,id=mem1,share=on,nopin=on,mem-path=$PATH,size=$NVDIMM_SIZE
-device nvdimm,id=nvdimm1,memdev=mem1
Where,
@@ -31,7 +31,7 @@ Where,
of normal RAM devices and vNVDIMM devices, e.g. $MAX_SIZE should be
>= $RAM_SIZE + $NVDIMM_SIZE here.
- - "object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE"
+ - "object memory-backend-file,id=mem1,share=on,nopin=on,mem-path=$PATH,size=$NVDIMM_SIZE"
creates a backend storage of size $NVDIMM_SIZE on a file $PATH. All
accesses to the virtual NVDIMM device go to the file $PATH.
@@ -42,6 +42,12 @@ Where,
"share=off", then guest writes won't be applied to the backend
file and thus will be invisible to other guests.
+ "nopin=on/off" controls the memory pining of memory backend file
+ during the VFIO device hotplug. If "nopin=on", then VFIO device
+ hotplug can skip the NVDIMM memory pining because qemu does not
+ need pining NVDIMM memory for devices. If "nopin=off", the VFIO
+ device hotplug need NVDIMM memory pining.
+
- "device nvdimm,id=nvdimm1,memdev=mem1" creates a virtual NVDIMM
device whose storage is provided by above memory backend device.
diff --git a/qemu-options.hx b/qemu-options.hx
index 981742d..d21ce2e 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -4173,7 +4173,7 @@ property must be set. These objects are placed in the
@table @option
-@item -object memory-backend-file,id=@var{id},size=@var{size},mem-path=@var{dir},share=@var{on|off},discard-data=@var{on|off}
+@item -object memory-backend-file,id=@var{id},size=@var{size},mem-path=@var{dir},share=@var{on|off},discard-data=@var{on|off},nopin=@var{on|off}
Creates a memory file backend object, which can be used to back
the guest RAM with huge pages. The @option{id} parameter is a
@@ -4191,6 +4191,10 @@ to avoid unnecessarily flushing data to the backing file. Note
that @option{discard-data} is only an optimization, and QEMU
might not discard file contents if it aborts unexpectedly or is
terminated using SIGKILL.
+Setting the @option{nopin} boolean option to @var{on} indicates
+that if the memory-backend-file is nvdimm or else, the memory
+pining can be disable during VFIO device hotplug. The default
+nopin is still off, which is same with previous value.
@item -object rng-random,id=@var{id},filename=@var{/dev/random}
--
1.9.1
next prev parent reply other threads:[~2017-10-16 8:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 8:56 [Qemu-devel] [PATCH 0/2] add "nopin" option in the memory-backend-file Yang Zhong
2017-10-16 8:56 ` [Qemu-devel] [PATCH 1/2] hostmem-file: Add "nopin" option for memory-backend-file Yang Zhong
2017-10-16 8:56 ` Yang Zhong [this message]
2017-10-16 10:20 ` [Qemu-devel] [PATCH 0/2] add "nopin" option in the memory-backend-file Xiao Guangrong
2017-10-16 11:58 ` Paolo Bonzini
2017-10-18 5:57 ` Zhong Yang
2017-10-18 9:48 ` Paolo Bonzini
2017-10-18 9:56 ` Zhong Yang
2017-10-18 5:34 ` Zhong Yang
2017-10-16 15:47 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508144183-30844-3-git-send-email-yang.zhong@intel.com \
--to=yang.zhong@intel.com \
--cc=alex.williamson@redhat.com \
--cc=anthony.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).