From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
BALATON Zoltan <balaton@eik.bme.hu>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init()
Date: Mon, 23 Oct 2017 10:49:15 +0200 [thread overview]
Message-ID: <1508748555.16488.4.camel@redhat.com> (raw)
In-Reply-To: <1508493233-1166-1-git-send-email-thuth@redhat.com>
On Fri, 2017-10-20 at 11:53 +0200, Thomas Huth wrote:
> The "cannot_instantiate_with_device_add_yet" flag has been renamed
> to "user_creatable" a while ago.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/display/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 6eddac9..7f18224 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1758,7 +1758,7 @@ static void sm501_sysbus_class_init(ObjectClass
> *klass, void *data)
> dc->reset = sm501_reset_sysbus;
> dc->vmsd = &vmstate_sm501_sysbus;
> /* Note: pointer property "chr-state" may remain null, thus
> - * no need for dc->cannot_instantiate_with_device_add_yet =
> true;
> + * no need for dc->user_creatable = false;
> */
> }
>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
next prev parent reply other threads:[~2017-10-23 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 9:53 [Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init() Thomas Huth
2017-10-23 8:49 ` Gerd Hoffmann [this message]
2017-10-27 14:03 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508748555.16488.4.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).