* [Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init()
@ 2017-10-20 9:53 Thomas Huth
2017-10-23 8:49 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2017-10-20 9:53 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Eduardo Habkost, BALATON Zoltan, David Gibson,
Gerd Hoffmann
The "cannot_instantiate_with_device_add_yet" flag has been renamed
to "user_creatable" a while ago.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/display/sm501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 6eddac9..7f18224 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -1758,7 +1758,7 @@ static void sm501_sysbus_class_init(ObjectClass *klass, void *data)
dc->reset = sm501_reset_sysbus;
dc->vmsd = &vmstate_sm501_sysbus;
/* Note: pointer property "chr-state" may remain null, thus
- * no need for dc->cannot_instantiate_with_device_add_yet = true;
+ * no need for dc->user_creatable = false;
*/
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init()
2017-10-20 9:53 [Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init() Thomas Huth
@ 2017-10-23 8:49 ` Gerd Hoffmann
2017-10-27 14:03 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Gerd Hoffmann @ 2017-10-23 8:49 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: qemu-trivial, Eduardo Habkost, BALATON Zoltan, David Gibson
On Fri, 2017-10-20 at 11:53 +0200, Thomas Huth wrote:
> The "cannot_instantiate_with_device_add_yet" flag has been renamed
> to "user_creatable" a while ago.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/display/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 6eddac9..7f18224 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1758,7 +1758,7 @@ static void sm501_sysbus_class_init(ObjectClass
> *klass, void *data)
> dc->reset = sm501_reset_sysbus;
> dc->vmsd = &vmstate_sm501_sysbus;
> /* Note: pointer property "chr-state" may remain null, thus
> - * no need for dc->cannot_instantiate_with_device_add_yet =
> true;
> + * no need for dc->user_creatable = false;
> */
> }
>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init()
2017-10-23 8:49 ` Gerd Hoffmann
@ 2017-10-27 14:03 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2017-10-27 14:03 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Thomas Huth, qemu-devel, qemu-trivial, Eduardo Habkost,
BALATON Zoltan
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
On Mon, Oct 23, 2017 at 10:49:15AM +0200, Gerd Hoffmann wrote:
> On Fri, 2017-10-20 at 11:53 +0200, Thomas Huth wrote:
> > The "cannot_instantiate_with_device_add_yet" flag has been renamed
> > to "user_creatable" a while ago.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > hw/display/sm501.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> > index 6eddac9..7f18224 100644
> > --- a/hw/display/sm501.c
> > +++ b/hw/display/sm501.c
> > @@ -1758,7 +1758,7 @@ static void sm501_sysbus_class_init(ObjectClass
> > *klass, void *data)
> > dc->reset = sm501_reset_sysbus;
> > dc->vmsd = &vmstate_sm501_sysbus;
> > /* Note: pointer property "chr-state" may remain null, thus
> > - * no need for dc->cannot_instantiate_with_device_add_yet =
> > true;
> > + * no need for dc->user_creatable = false;
> > */
> > }
> >
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Applied to ppc-for-2.11, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-27 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-20 9:53 [Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init() Thomas Huth
2017-10-23 8:49 ` Gerd Hoffmann
2017-10-27 14:03 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).