From: Gerd Hoffmann <kraxel@redhat.com>
To: Jindrich Makovicka <makovick@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/7] sdl2: Do not quit the emulator when an auxilliary window is closed
Date: Wed, 01 Nov 2017 11:39:17 +0100 [thread overview]
Message-ID: <1509532757.3856.6.camel@redhat.com> (raw)
In-Reply-To: <20171023210803.20998-3-makovick@gmail.com>
On Mon, 2017-10-23 at 23:07 +0200, Jindrich Makovicka wrote:
> ---
> ui/sdl2.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/ui/sdl2.c b/ui/sdl2.c
> index 7f51933234..aa37b39547 100644
> --- a/ui/sdl2.c
> +++ b/ui/sdl2.c
> @@ -566,9 +566,13 @@ static void handle_windowevent(SDL_Event *ev)
> update_displaychangelistener(&scon->dcl, 500);
> break;
> case SDL_WINDOWEVENT_CLOSE:
> - if (!no_quit) {
> - no_shutdown = 0;
> - qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_UI);
> + if (qemu_console_is_graphic(scon->dcl.con)) {
> + if (!no_quit) {
> + no_shutdown = 0;
> + qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_UI)
> ;
> + }
> + } else {
> + SDL_HideWindow(scon->real_window);
scon->hidden should be update here.
> }
> break;
> case SDL_WINDOWEVENT_SHOWN:
next prev parent reply other threads:[~2017-11-01 10:39 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 21:07 [Qemu-devel] SDL2 various fixes Jindrich Makovicka
2017-10-23 21:07 ` [Qemu-devel] [PATCH 1/7] sdl2: Fix broken display updating after the window is hidden Jindrich Makovicka
2017-11-01 10:37 ` Gerd Hoffmann
2017-10-23 21:07 ` [Qemu-devel] [PATCH 2/7] sdl2: Do not quit the emulator when an auxilliary window is closed Jindrich Makovicka
2017-11-01 10:39 ` Gerd Hoffmann [this message]
2017-10-23 21:07 ` [Qemu-devel] [PATCH 3/7] sdl2: Do not hide the cursor on auxilliary windows Jindrich Makovicka
2017-10-24 2:38 ` Philippe Mathieu-Daudé
2017-10-24 17:39 ` Jindřich Makovička
2017-10-23 21:08 ` [Qemu-devel] [PATCH 4/7] sdl2: Only accept the hotkeys on the main window Jindrich Makovicka
2017-11-01 10:40 ` Gerd Hoffmann
2017-11-02 17:12 ` Jindřich Makovička
2017-11-03 9:26 ` Gerd Hoffmann
2017-11-03 9:37 ` Peter Maydell
2017-11-03 10:35 ` Gerd Hoffmann
2017-11-03 10:41 ` Peter Maydell
2017-11-03 10:45 ` Daniel P. Berrange
2017-11-03 11:01 ` Gerd Hoffmann
2017-11-03 11:10 ` Peter Maydell
2017-11-03 12:07 ` Gerd Hoffmann
2017-11-03 12:10 ` Peter Maydell
2017-11-03 12:34 ` Gerd Hoffmann
2017-11-05 14:10 ` Cole Robinson
2017-11-08 10:10 ` Gerd Hoffmann
2017-11-08 19:15 ` Jindřich Makovička
2017-10-23 21:08 ` [Qemu-devel] [PATCH 5/7] sdl2 uses surface relative coordinates Jindrich Makovicka
2017-11-01 10:43 ` Gerd Hoffmann
2017-11-02 17:07 ` Jindřich Makovička
2017-11-03 9:53 ` Gerd Hoffmann
2017-10-23 21:08 ` [Qemu-devel] [PATCH 6/7] sdl2: Fix dead keyboard after fullsceen Jindrich Makovicka
2017-10-23 21:08 ` [Qemu-devel] [PATCH 7/7] sdl2: Do not leave grab when fullscreen Jindrich Makovicka
2017-10-24 2:40 ` [Qemu-devel] SDL2 various fixes Philippe Mathieu-Daudé
2017-11-12 10:42 ` [Qemu-devel] [PATCH] " Jindrich Makovicka
2017-11-12 10:42 ` [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden Jindrich Makovicka
2017-11-12 10:42 ` [Qemu-devel] [PATCH 2/8] sdl2: Do not quit the emulator when an auxilliary window is closed Jindrich Makovicka
2017-11-12 10:42 ` [Qemu-devel] [PATCH 3/8] sdl2: Use the same pointer show/hide logic for absolute and relative mode Jindrich Makovicka
2017-11-12 10:42 ` [Qemu-devel] [PATCH 4/8] sdl2: Do not hide the cursor on auxilliary windows Jindrich Makovicka
2017-11-12 10:42 ` [Qemu-devel] [PATCH 5/8] sdl2 uses surface relative coordinates Jindrich Makovicka
2017-11-12 10:42 ` [Qemu-devel] [PATCH 6/8] sdl2: Fix dead keyboard after fullsceen Jindrich Makovicka
2017-11-12 10:42 ` [Qemu-devel] [PATCH 7/8] sdl2: Do not leave grab when fullscreen Jindrich Makovicka
2017-11-12 10:42 ` [Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held Jindrich Makovicka
2017-11-12 17:17 ` [Qemu-devel] [PATCH] SDL2 various fixes Philippe Mathieu-Daudé
2017-11-12 19:30 ` [Qemu-devel] [PATCH v3] " Jindrich Makovicka
2017-11-12 19:30 ` [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden Jindrich Makovicka
2017-11-13 12:39 ` Gerd Hoffmann
2017-11-13 12:59 ` Gerd Hoffmann
2017-11-13 13:17 ` Jindřich Makovička
2017-11-13 13:38 ` Gerd Hoffmann
2017-11-13 16:35 ` Max Reitz
2017-11-14 9:53 ` Gerd Hoffmann
2017-11-14 14:48 ` Max Reitz
2017-11-14 15:12 ` Gerd Hoffmann
2017-11-12 19:30 ` [Qemu-devel] [PATCH 2/8] sdl2: Do not quit the emulator when an auxilliary window is closed Jindrich Makovicka
2017-11-12 19:30 ` [Qemu-devel] [PATCH 3/8] sdl2: Use the same pointer show/hide logic for absolute and relative mode Jindrich Makovicka
2017-11-12 19:30 ` [Qemu-devel] [PATCH 4/8] sdl2: Do not hide the cursor on auxilliary windows Jindrich Makovicka
2017-11-13 13:21 ` Gerd Hoffmann
2017-11-12 19:30 ` [Qemu-devel] [PATCH 5/8] sdl2 uses surface relative coordinates Jindrich Makovicka
2017-11-13 13:22 ` Gerd Hoffmann
2017-11-12 19:30 ` [Qemu-devel] [PATCH 6/8] sdl2: Fix dead keyboard after fullsceen Jindrich Makovicka
2017-11-12 19:30 ` [Qemu-devel] [PATCH 7/8] sdl2: Do not leave grab when fullscreen Jindrich Makovicka
2017-11-12 19:30 ` [Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held Jindrich Makovicka
2017-11-13 13:29 ` Gerd Hoffmann
2017-11-13 13:34 ` [Qemu-devel] [PATCH v3] SDL2 various fixes Gerd Hoffmann
2017-11-13 15:46 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509532757.3856.6.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=makovick@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).