From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
eblake@redhat.com, den@virtuozzo.com, berto@igalia.com,
Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v5 05/15] file-posix: support BDRV_REQ_ALLOCATE
Date: Wed, 1 Nov 2017 18:43:58 +0300 [thread overview]
Message-ID: <1509551048-129830-6-git-send-email-anton.nefedov@virtuozzo.com> (raw)
In-Reply-To: <1509551048-129830-1-git-send-email-anton.nefedov@virtuozzo.com>
Current write_zeroes implementation is good enough to satisfy this flag too
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
block/file-posix.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 36ee89e..c36e156 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -558,7 +558,10 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
}
if (S_ISREG(st.st_mode)) {
s->discard_zeroes = true;
+#ifdef CONFIG_FALLOCATE
s->has_fallocate = true;
+ bs->supported_zero_flags |= BDRV_REQ_ALLOCATE;
+#endif
}
if (S_ISBLK(st.st_mode)) {
#ifdef BLKDISCARDZEROES
@@ -593,6 +596,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
#ifdef CONFIG_XFS
if (platform_test_xfs_fd(s->fd)) {
s->is_xfs = true;
+ bs->supported_zero_flags |= BDRV_REQ_ALLOCATE;
}
#endif
@@ -1413,6 +1417,10 @@ static ssize_t handle_aiocb_write_zeroes(RawPosixAIOData *aiocb)
}
s->has_fallocate = false;
}
+
+ if (!s->has_fallocate) {
+ aiocb->bs->supported_zero_flags &= ~BDRV_REQ_ALLOCATE;
+ }
#endif
return -ENOTSUP;
--
2.7.4
next prev parent reply other threads:[~2017-11-01 15:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 15:43 [Qemu-devel] [PATCH v5 00/15] qcow2: space preallocation and COW improvements Anton Nefedov
2017-11-01 15:43 ` [Qemu-devel] [PATCH v5 01/15] mirror: inherit supported write/zero flags Anton Nefedov
2018-01-11 14:14 ` Alberto Garcia
2017-11-01 15:43 ` [Qemu-devel] [PATCH v5 02/15] blkverify: set " Anton Nefedov
2018-01-11 14:17 ` Alberto Garcia
2017-11-01 15:43 ` [Qemu-devel] [PATCH v5 03/15] block: introduce BDRV_REQ_ALLOCATE flag Anton Nefedov
2017-11-01 15:43 ` [Qemu-devel] [PATCH v5 04/15] block: treat BDRV_REQ_ALLOCATE as serialising Anton Nefedov
2017-11-01 15:43 ` Anton Nefedov [this message]
2017-11-01 15:43 ` [Qemu-devel] [PATCH v5 06/15] block: support BDRV_REQ_ALLOCATE in passthrough drivers Anton Nefedov
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 07/15] qcow2: move is_zero() up Anton Nefedov
2018-01-15 15:14 ` Alberto Garcia
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 08/15] qcow2: skip writing zero buffers to empty COW areas Anton Nefedov
2018-01-15 15:31 ` Alberto Garcia
2018-01-15 18:21 ` Anton Nefedov
2018-01-15 20:12 ` Alberto Garcia
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 09/15] qcow2: preallocation at image expand Anton Nefedov
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 10/15] qcow2: set inactive flag Anton Nefedov
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 11/15] qcow2: truncate preallocated space Anton Nefedov
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 12/15] qcow2: check space leak at the end of the image Anton Nefedov
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 13/15] qcow2: do not zero out clusters if already preallocated Anton Nefedov
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 14/15] iotest 198: test BDRV_REQ_ALLOCATE Anton Nefedov
2017-11-01 15:44 ` [Qemu-devel] [PATCH v5 15/15] iotest 134: test cluster-misaligned encrypted write Anton Nefedov
2017-12-04 22:32 ` [Qemu-devel] [Qemu-block] [PATCH v5 00/15] qcow2: space preallocation and COW improvements John Snow
2017-12-05 17:28 ` Anton Nefedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509551048-129830-6-git-send-email-anton.nefedov@virtuozzo.com \
--to=anton.nefedov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).