From: Gerd Hoffmann <kraxel@redhat.com>
To: Ladi Prosek <lprosek@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Yan Vugenfirer <yvugenfi@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Vadim Rozenfeld <vrozenfe@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID
Date: Fri, 03 Nov 2017 08:20:37 +0100 [thread overview]
Message-ID: <1509693637.31823.7.camel@redhat.com> (raw)
In-Reply-To: <CABdb734XVCNxyyRUfFtU5cm=34K28zsuRgyuj6F2SEBjPUu27w@mail.gmail.com>
> > > Signed-off-by: Ladi Prosek <lprosek@redhat.com>
> >
> > I wonder whether it's a problem that legacy devices ignore
> > the subsystem ID (that's part of spec).
>
> I don't understand this comment. I don't see anything in the spec
> related to ignoring the subsystem ID.
Well, the subsystem *device* id is defined to be the virtio device id,
so it is certainly not ignored. The subsystem *vendor* id is not used
as far I know (or ignored in the sense that it doesn't change driver
behavior), allowing to set that makes sense to me.
Possibly not only for virtio devices, most pci devices have 1af4:1100
as subsystem id, other vendors might want set it too for consistency.
cheers,
Gerd
next prev parent reply other threads:[~2017-11-03 7:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 13:31 [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID Ladi Prosek
2017-11-02 14:52 ` Michael S. Tsirkin
2017-11-03 6:25 ` Ladi Prosek
2017-11-03 7:20 ` Gerd Hoffmann [this message]
2017-11-03 8:23 ` Ladi Prosek
2017-11-03 8:44 ` Vadim Rozenfeld
2017-11-03 15:11 ` Michael S. Tsirkin
2017-11-06 9:02 ` Ladi Prosek
2017-11-06 9:18 ` Gerd Hoffmann
2017-11-06 16:53 ` Michael S. Tsirkin
2017-11-06 16:51 ` Michael S. Tsirkin
2017-11-07 8:30 ` Ladi Prosek
2017-11-03 15:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509693637.31823.7.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=lprosek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vrozenfe@redhat.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).