Re: [Qemu-devel] [PULL 0/3] TCG queued patches

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 0/3] TCG queued patches
Type: series
Message-id: 20171103084046.12821-1-richard.henderson@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1509640536-32160-1-git-send-email-peter.maydell@linaro.org -> patchew/1509640536-32160-1-git-send-email-peter.maydell@linaro.org
 t [tag update]            patchew/20171102180310.24760-1-dgilbert@redhat.com -> patchew/20171102180310.24760-1-dgilbert@redhat.com
 * [new tag]               patchew/20171103084046.12821-1-richard.henderson@linaro.org -> patchew/20171103084046.12821-1-richard.henderson@linaro.org
Switched to a new branch 'test'
289026f1da cpu-exec: Exit exclusive region on longjmp from step_atomic
b0dafca64f tcg/s390x: Use constant pool for prologue
9beb4b93f1 tcg: Allow constant pool entries in the prologue

=== OUTPUT BEGIN ===
Checking PATCH 1/3: tcg: Allow constant pool entries in the prologue...
Checking PATCH 2/3: tcg/s390x: Use constant pool for prologue...
Checking PATCH 3/3: cpu-exec: Exit exclusive region on longjmp from step_atomic...
ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#45: FILE: accel/tcg/cpu-exec.c:237:
+    volatile bool in_exclusive_region = false;

total: 1 errors, 0 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org