From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAYFg-0007DC-88 for qemu-devel@nongnu.org; Fri, 03 Nov 2017 05:27:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAYFd-0006Va-4h for qemu-devel@nongnu.org; Fri, 03 Nov 2017 05:27:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34066) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eAYFc-0006Uo-Ue for qemu-devel@nongnu.org; Fri, 03 Nov 2017 05:26:57 -0400 Message-ID: <1509701213.31823.11.camel@redhat.com> From: Gerd Hoffmann Date: Fri, 03 Nov 2017 10:26:53 +0100 In-Reply-To: References: <20171023210803.20998-1-makovick@gmail.com> <20171023210803.20998-5-makovick@gmail.com> <1509532830.3856.7.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/7] sdl2: Only accept the hotkeys on the main window List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Jind=C5=99ich_Makovi=C4=8Dka?= Cc: qemu-devel@nongnu.org On Thu, 2017-11-02 at 17:12 +0000, Jind=C5=99ich Makovi=C4=8Dka wrote: > This fixes the following case: >=20 > 1) Ctrl-Alt-2 for console is pressed > 2) console pops up and gets focus > 3) console receives the Ctrl-Alt-2 keypress event Hmm, doesn't reproduce here. Also: why should the same event be delivered twice? Ignoring autorepeat events (as the patch does, but which the commit message doesn't mention) makes sense. But I still fail to see why we should limit hotkeys to the main window. cheers, Gerd