qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: marcandre.lureau@gmail.com, qemu-devel@nongnu.org,
	amarnath.valluri@intel.com
Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v3 for-2.11 3/3] tpm_tis: Return 0 for every register in case of failure mode
Date: Tue, 14 Nov 2017 16:52:29 -0500	[thread overview]
Message-ID: <1510696349-5151-4-git-send-email-stefanb@linux.vnet.ibm.com> (raw)
In-Reply-To: <1510696349-5151-1-git-send-email-stefanb@linux.vnet.ibm.com>

Rather than returning ~0, return 0 for every register in case of
failure mode. The '0' is better to indicate that there's no device
there.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
 hw/tpm/tpm_tis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index fec2fc6..42d647d 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -545,7 +545,7 @@ static uint64_t tpm_tis_mmio_read(void *opaque, hwaddr addr,
     uint8_t v;
 
     if (tpm_backend_had_startup_error(s->be_driver)) {
-        return val;
+        return 0;
     }
 
     switch (offset) {
-- 
2.5.5

  parent reply	other threads:[~2017-11-14 21:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 21:52 [Qemu-devel] [PATCH v3 for-2.11 0/3] tpm: a few fixes Stefan Berger
2017-11-14 21:52 ` [Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag Stefan Berger
2017-11-14 23:40   ` Marc-André Lureau
2017-11-15  1:16     ` Stefan Berger
2017-11-15  3:47       ` Marc-André Lureau
2017-11-15  9:05         ` Valluri, Amarnath
2017-12-05 20:56           ` Stefan Berger
2017-11-15 12:18         ` Stefan Berger
2017-12-20 16:24   ` Marc-André Lureau
2017-11-14 21:52 ` [Qemu-devel] [PATCH v3 for-2.11 2/3] tpm_tis: Return TPM_VERSION_UNSPEC in case of BE failure Stefan Berger
2017-11-14 23:41   ` Marc-André Lureau
2017-11-14 21:52 ` Stefan Berger [this message]
2017-11-14 23:47   ` [Qemu-devel] [PATCH v3 for-2.11 3/3] tpm_tis: Return 0 for every register in case of failure mode Marc-André Lureau
2017-11-15  1:18     ` Stefan Berger
2017-11-15  3:45       ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510696349-5151-4-git-send-email-stefanb@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=amarnath.valluri@intel.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).