From: Chao Gao <chao.gao@intel.com>
To: qemu-devel@nongnu.org
Cc: Chao Gao <chao.gao@intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>,
Peter Xu <peterx@redhat.com>, Lan Tianyu <tianyu.lan@intel.com>
Subject: [Qemu-devel] [PATCH v3 1/3] i386/msi: Correct mask of destination ID in MSI address
Date: Fri, 17 Nov 2017 14:24:23 +0800 [thread overview]
Message-ID: <1510899865-40323-2-git-send-email-chao.gao@intel.com> (raw)
In-Reply-To: <1510899865-40323-1-git-send-email-chao.gao@intel.com>
According to SDM 10.11.1, only [19:12] bits of MSI address are
Destination ID, change the mask to avoid ambiguity for VT-d spec
has used the bit 4 to indicate a remappable interrupt request.
Signed-off-by: Chao Gao <chao.gao@intel.com>
Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
include/hw/i386/apic-msidef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h
index 8b4d4cc..420b411 100644
--- a/include/hw/i386/apic-msidef.h
+++ b/include/hw/i386/apic-msidef.h
@@ -26,6 +26,6 @@
#define MSI_ADDR_DEST_ID_SHIFT 12
#define MSI_ADDR_DEST_IDX_SHIFT 4
-#define MSI_ADDR_DEST_ID_MASK 0x00ffff0
+#define MSI_ADDR_DEST_ID_MASK 0x000ff000
#endif /* HW_APIC_MSIDEF_H */
--
1.8.3.1
next prev parent reply other threads:[~2017-11-17 6:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 6:24 [Qemu-devel] [PATCH v3 0/3] Qemu: add Xen vIOMMU interrupt remapping function support Chao Gao
2017-11-17 6:24 ` Chao Gao [this message]
2017-11-17 13:24 ` [Qemu-devel] [PATCH v3 1/3] i386/msi: Correct mask of destination ID in MSI address Michael S. Tsirkin
2017-11-20 7:56 ` Chao Gao
2017-11-17 6:24 ` [Qemu-devel] [PATCH v3 2/3] xen/pt: Pass the whole msi addr/data to Xen Chao Gao
2017-12-11 17:59 ` Anthony PERARD
2017-12-11 18:28 ` Chao Gao
2017-11-17 6:24 ` [Qemu-devel] [PATCH v3 3/3] msi: Handle remappable format interrupt request Chao Gao
2017-12-11 18:07 ` Anthony PERARD
2017-12-11 18:35 ` Chao Gao
2017-11-17 6:58 ` [Qemu-devel] [PATCH v3 0/3] Qemu: add Xen vIOMMU interrupt remapping function support no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510899865-40323-2-git-send-email-chao.gao@intel.com \
--to=chao.gao@intel.com \
--cc=anthony.perard@citrix.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).