* [Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h
@ 2017-11-21 15:07 Peter Maydell
2017-11-21 16:00 ` Philippe Mathieu-Daudé
2017-11-21 20:01 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2017-11-21 15:07 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: patches
The cpu-exec-common.c file includes memory-internal.h, but it doesn't
actually use anything from that header. Remove the unnecessary include.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
accel/tcg/cpu-exec-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c
index 5b4ae54..dac5aac 100644
--- a/accel/tcg/cpu-exec-common.c
+++ b/accel/tcg/cpu-exec-common.c
@@ -21,7 +21,6 @@
#include "cpu.h"
#include "sysemu/cpus.h"
#include "exec/exec-all.h"
-#include "exec/memory-internal.h"
bool tcg_allowed;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h
2017-11-21 15:07 [Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h Peter Maydell
@ 2017-11-21 16:00 ` Philippe Mathieu-Daudé
2017-11-21 20:01 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-11-21 16:00 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: patches
On 11/21/2017 12:07 PM, Peter Maydell wrote:
> The cpu-exec-common.c file includes memory-internal.h, but it doesn't
> actually use anything from that header. Remove the unnecessary include.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> accel/tcg/cpu-exec-common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c
> index 5b4ae54..dac5aac 100644
> --- a/accel/tcg/cpu-exec-common.c
> +++ b/accel/tcg/cpu-exec-common.c
> @@ -21,7 +21,6 @@
> #include "cpu.h"
> #include "sysemu/cpus.h"
> #include "exec/exec-all.h"
> -#include "exec/memory-internal.h"
>
> bool tcg_allowed;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h
2017-11-21 15:07 [Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h Peter Maydell
2017-11-21 16:00 ` Philippe Mathieu-Daudé
@ 2017-11-21 20:01 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2017-11-21 20:01 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: patches
On 11/21/2017 04:07 PM, Peter Maydell wrote:
> The cpu-exec-common.c file includes memory-internal.h, but it doesn't
> actually use anything from that header. Remove the unnecessary include.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> accel/tcg/cpu-exec-common.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-21 20:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-21 15:07 [Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h Peter Maydell
2017-11-21 16:00 ` Philippe Mathieu-Daudé
2017-11-21 20:01 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).