From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJncQ-0002yI-Bk for qemu-devel@nongnu.org; Tue, 28 Nov 2017 16:40:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJncL-0001Jx-GC for qemu-devel@nongnu.org; Tue, 28 Nov 2017 16:40:42 -0500 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:33040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJncL-0001JH-8W for qemu-devel@nongnu.org; Tue, 28 Nov 2017 16:40:37 -0500 Received: by mail-lf0-x244.google.com with SMTP id 74so1531048lfs.0 for ; Tue, 28 Nov 2017 13:40:36 -0800 (PST) From: Vasyl Gomonovych Date: Tue, 28 Nov 2017 22:40:27 +0100 Message-Id: <1511905227-30292-1-git-send-email-gomonovych@gmail.com> Subject: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: somlo@cmu.edu, mst@redhat.com, qemu-devel@nongnu.org Cc: linux-kernel@vger.kernel.org, gomonovych@gmail.com Fix ptr_ret.cocci warnings: drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Vasyl Gomonovych --- drivers/firmware/qemu_fw_cfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 5cfe39f7a45f..18489b6a696d 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp) */ fw_cfg_cmdline_dev = platform_device_register_simple("fw_cfg", PLATFORM_DEVID_NONE, res, processed); - if (IS_ERR(fw_cfg_cmdline_dev)) - return PTR_ERR(fw_cfg_cmdline_dev); - return 0; + return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev); } static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp) -- 1.9.1