qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [Qemu-devel] [PULL 2/7] virtio: Add queue interface to restore avail index from vring used index
Date: Fri, 1 Dec 2017 19:08:43 +0200	[thread overview]
Message-ID: <1512148088-28733-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1512148088-28733-1-git-send-email-mst@redhat.com>

From: Maxime Coquelin <maxime.coquelin@redhat.com>

In case of backend crash, it is not possible to restore internal
avail index from the backend value as vhost_get_vring_base
callback fails.

This patch provides a new interface to restore internal avail index
from the vring used index, as done by some vhost-user backend on
reconnection.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/virtio/virtio.h |  1 +
 hw/virtio/virtio.c         | 10 ++++++++++
 2 files changed, 11 insertions(+)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 5abada6..098bdaa 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -272,6 +272,7 @@ hwaddr virtio_queue_get_avail_size(VirtIODevice *vdev, int n);
 hwaddr virtio_queue_get_used_size(VirtIODevice *vdev, int n);
 uint16_t virtio_queue_get_last_avail_idx(VirtIODevice *vdev, int n);
 void virtio_queue_set_last_avail_idx(VirtIODevice *vdev, int n, uint16_t idx);
+void virtio_queue_restore_last_avail_idx(VirtIODevice *vdev, int n);
 void virtio_queue_invalidate_signalled_used(VirtIODevice *vdev, int n);
 void virtio_queue_update_used_idx(VirtIODevice *vdev, int n);
 VirtQueue *virtio_get_queue(VirtIODevice *vdev, int n);
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index ea532dc..703e672 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2310,6 +2310,16 @@ void virtio_queue_set_last_avail_idx(VirtIODevice *vdev, int n, uint16_t idx)
     vdev->vq[n].shadow_avail_idx = idx;
 }
 
+void virtio_queue_restore_last_avail_idx(VirtIODevice *vdev, int n)
+{
+    rcu_read_lock();
+    if (vdev->vq[n].vring.desc) {
+        vdev->vq[n].last_avail_idx = vring_used_idx(&vdev->vq[n]);
+        vdev->vq[n].shadow_avail_idx = vdev->vq[n].last_avail_idx;
+    }
+    rcu_read_unlock();
+}
+
 void virtio_queue_update_used_idx(VirtIODevice *vdev, int n)
 {
     rcu_read_lock();
-- 
MST

  parent reply	other threads:[~2017-12-01 17:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 17:08 [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3 Michael S. Tsirkin
2017-12-01 17:08 ` [Qemu-devel] [PULL 1/7] i386/msi: Correct mask of destination ID in MSI address Michael S. Tsirkin
2017-12-01 17:08 ` Michael S. Tsirkin [this message]
2017-12-01 17:08 ` [Qemu-devel] [PULL 3/7] vhost: restore avail index from vring used index on disconnection Michael S. Tsirkin
2017-12-01 17:08 ` [Qemu-devel] [PULL 4/7] dump-guest-memory.py: fix No symbol "vmcoreinfo_find" Michael S. Tsirkin
2017-12-01 17:08 ` [Qemu-devel] [PULL 5/7] vhost: fix error check in vhost_verify_ring_mappings() Michael S. Tsirkin
2017-12-01 17:08 ` [Qemu-devel] [PULL 6/7] virtio: check VirtQueue Vring object is set Michael S. Tsirkin
2017-12-01 17:09 ` [Qemu-devel] [PULL 7/7] pc: fix crash on attempted cpu unplug Michael S. Tsirkin
2017-12-01 18:05 ` [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3 Peter Maydell
2017-12-03  4:56   ` Michael S. Tsirkin
2017-12-04 10:16     ` Peter Maydell
2017-12-04 17:18       ` Peter Maydell
2017-12-05  0:56       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512148088-28733-3-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).