qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: minyard@acm.org
To: qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>
Subject: [Qemu-devel] [PATCH 6/7] smbios:ipmi: Ignore IPMI devices with no fwinfo function
Date: Thu,  7 Dec 2017 15:34:48 -0600	[thread overview]
Message-ID: <1512682489-4474-7-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1512682489-4474-1-git-send-email-minyard@acm.org>

From: Corey Minyard <cminyard@mvista.com>

Not all devices have fwinfo (like the coming PCI one), so ignore
them if the their fwinfo function is NULL.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
 hw/smbios/smbios_type_38.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/smbios/smbios_type_38.c b/hw/smbios/smbios_type_38.c
index 56e8609..5475323 100644
--- a/hw/smbios/smbios_type_38.c
+++ b/hw/smbios/smbios_type_38.c
@@ -95,6 +95,9 @@ static void smbios_add_ipmi_devices(BusState *bus)
             ii = IPMI_INTERFACE(obj);
             iic = IPMI_INTERFACE_GET_CLASS(obj);
             memset(&info, 0, sizeof(info));
+            if (!iic->get_fwinfo) {
+                continue;
+            }
             iic->get_fwinfo(ii, &info);
             smbios_build_one_type_38(&info);
             continue;
-- 
2.7.4

  parent reply	other threads:[~2017-12-07 21:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 21:34 [Qemu-devel] [PATCH 0/7] Add PCI IPMI interfaces minyard
2017-12-07 21:34 ` [Qemu-devel] [PATCH 1/7] ipmi: Use proper struct reference for KCS vmstate minyard
2017-12-07 21:34 ` [Qemu-devel] [PATCH 2/7] ipmi: Use proper struct reference for BT vmstate minyard
2017-12-07 21:34 ` [Qemu-devel] [PATCH 3/7] ipmi: Split out KCS-specific code from ISA KCS code minyard
2017-12-07 21:34 ` [Qemu-devel] [PATCH 4/7] ipmi: Split out BT-specific code from ISA BT code minyard
2017-12-07 21:34 ` [Qemu-devel] [PATCH 5/7] ipmi: Allow a size value to be passed for I/O space minyard
2017-12-07 21:34 ` minyard [this message]
2017-12-07 21:34 ` [Qemu-devel] [PATCH 7/7] ipmi: Add PCI IPMI interfaces minyard
2017-12-07 21:45 ` [Qemu-devel] [PATCH 0/7] " Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512682489-4474-7-git-send-email-minyard@acm.org \
    --to=minyard@acm.org \
    --cc=cminyard@mvista.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).