From: Sam Bobroff <sam.bobroff@au1.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
Date: Wed, 4 Jun 2014 11:37:03 +1000 [thread overview]
Message-ID: <1513018f45cbc2dfff157d5df1dc86246cf08843.1401845262.git.sam.bobroff@au1.ibm.com> (raw)
Allow "make install" to handle tool binaries that reside in
sub-directories.
Without this patch "make install" will fail if it needs to strip
a tool binary (e.g. debugging is not enabled) that is installed
from a subdirectory. An example is fsdev/virtfs-proxy-helper.
Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index d830483..9c23265 100644
--- a/Makefile
+++ b/Makefile
@@ -380,7 +380,7 @@ install-datadir install-localstatedir
ifneq ($(TOOLS),)
$(INSTALL_PROG) $(TOOLS) "$(DESTDIR)$(bindir)"
ifneq ($(STRIP),)
- $(STRIP) $(TOOLS:%="$(DESTDIR)$(bindir)/%")
+ $(STRIP) $(foreach T,$(TOOLS),"$(DESTDIR)$(bindir)/$(notdir $T)")
endif
endif
ifneq ($(CONFIG_MODULES),)
--
1.7.10.4
next reply other threads:[~2014-06-04 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 1:37 Sam Bobroff [this message]
2014-06-04 8:24 ` [Qemu-devel] [PATCH 1/1] Makefile: Correct path in stripping tool binaries Peter Maydell
2014-06-22 6:30 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-06-22 6:52 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513018f45cbc2dfff157d5df1dc86246cf08843.1401845262.git.sam.bobroff@au1.ibm.com \
--to=sam.bobroff@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).