From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, qemu-ppc@nongnu.org, clg@kaod.org,
lo1@us.ibm.com, James.Bottomley@HansenPartnership.com,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v2 2/2] tpm_spapr: Support suspend and resume
Date: Tue, 12 Dec 2017 15:44:03 -0500 [thread overview]
Message-ID: <1513111443-22790-3-git-send-email-stefanb@linux.vnet.ibm.com> (raw)
In-Reply-To: <1513111443-22790-1-git-send-email-stefanb@linux.vnet.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
hw/tpm/tpm_spapr.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 57 insertions(+), 4 deletions(-)
diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c
index ef5e62d..0b8a424 100644
--- a/hw/tpm/tpm_spapr.c
+++ b/hw/tpm/tpm_spapr.c
@@ -248,9 +248,8 @@ static int tpm_spapr_do_crq(struct VIOsPAPRDevice *dev, uint8_t *crq_data)
return H_SUCCESS;
}
-static void tpm_spapr_request_completed(TPMIf *ti)
+static void _tpm_spapr_request_completed(SPAPRvTPMState *s)
{
- SPAPRvTPMState *s = VIO_SPAPR_VTPM(ti);
TPMSpaprCRQ *crq = &s->crq;
uint32_t len;
int rc;
@@ -281,6 +280,13 @@ static void tpm_spapr_request_completed(TPMIf *ti)
}
}
+static void tpm_spapr_request_completed(TPMIf *ti)
+{
+ SPAPRvTPMState *s = VIO_SPAPR_VTPM(ti);
+
+ _tpm_spapr_request_completed(s);
+}
+
static int tpm_spapr_do_startup_tpm(SPAPRvTPMState *s, size_t buffersize)
{
return tpm_backend_startup_tpm(s->be_driver, buffersize);
@@ -313,9 +319,56 @@ static enum TPMVersion tpm_spapr_get_version(TPMIf *ti)
return tpm_backend_get_tpm_version(s->be_driver);
}
+/* persistent state handling */
+
+static int tpm_spapr_pre_save(void *opaque)
+{
+ SPAPRvTPMState *s = opaque;
+
+ /*
+ * Synchronize with backend completion.
+ */
+ tpm_backend_wait_cmd_completed(s->be_driver);
+
+ /*
+ * we cannot deliver the results to the VM (in state
+ * SPAPR_VTPM_STATE_EXECUTION) since DMA would touch VM memory
+ */
+
+ return 0;
+}
+
+static int tpm_spapr_post_load(void *opaque,
+ int version_id __attribute__((unused)))
+{
+ SPAPRvTPMState *s = opaque;
+
+ if (s->state == SPAPR_VTPM_STATE_EXECUTION) {
+ /*
+ * now we can deliver the results to the VM via DMA
+ */
+ _tpm_spapr_request_completed(s);
+ }
+
+ return 0;
+}
+
static const VMStateDescription vmstate_spapr_vtpm = {
- .name = "tpm_spapr",
- .unmigratable = 1,
+ .name = "tpm-spapr",
+ .version_id = 1,
+ .minimum_version_id = 0,
+ .minimum_version_id_old = 0,
+ .pre_save = tpm_spapr_pre_save,
+ .post_load = tpm_spapr_post_load,
+ .fields = (VMStateField[]) {
+ VMSTATE_BUFFER(crq.raw, SPAPRvTPMState),
+ VMSTATE_UINT64(vdev.crq.qladdr, SPAPRvTPMState),
+ VMSTATE_UINT32(vdev.crq.qsize, SPAPRvTPMState),
+ VMSTATE_UINT32(vdev.crq.qnext, SPAPRvTPMState),
+ VMSTATE_UINT8(state, SPAPRvTPMState),
+ VMSTATE_BUFFER(buffer, SPAPRvTPMState),
+ VMSTATE_END_OF_LIST(),
+ }
};
static Property tpm_spapr_properties[] = {
--
2.5.5
next prev parent reply other threads:[~2017-12-12 20:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 20:44 [Qemu-devel] [PATCH v2 0/2] Add vTPM emulator supportfor ppc64 platform Stefan Berger
2017-12-12 20:44 ` [Qemu-devel] [PATCH v2 1/2] tpm_spapr: Support TPM for ppc64 using CRQ based interface Stefan Berger
2018-07-26 5:26 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2018-07-26 17:20 ` Stefan Berger
2017-12-12 20:44 ` Stefan Berger [this message]
2018-07-26 5:31 ` [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] tpm_spapr: Support suspend and resume David Gibson
2018-07-26 14:01 ` Eric Blake
2018-08-31 13:29 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513111443-22790-3-git-send-email-stefanb@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=clg@kaod.org \
--cc=lo1@us.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).