From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayiqc-0001xe-KM for qemu-devel@nongnu.org; Fri, 06 May 2016 12:43:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayiqR-0002Ci-4N for qemu-devel@nongnu.org; Fri, 06 May 2016 12:43:21 -0400 Received: from mail-qg0-x242.google.com ([2607:f8b0:400d:c04::242]:33555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayiqP-00028O-PI for qemu-devel@nongnu.org; Fri, 06 May 2016 12:43:15 -0400 Received: by mail-qg0-x242.google.com with SMTP id 90so7193801qgz.0 for ; Fri, 06 May 2016 09:42:59 -0700 (PDT) Sender: Richard Henderson References: <1462392752-17703-1-git-send-email-laurent@vivier.eu> <1462392752-17703-8-git-send-email-laurent@vivier.eu> From: Richard Henderson Message-ID: <15131fb5-97ca-cfe1-a3f5-46beb9aa1c83@twiddle.net> Date: Fri, 6 May 2016 06:42:51 -1000 MIME-Version: 1.0 In-Reply-To: <1462392752-17703-8-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/52] target-m68k: add bkpt instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: gerg@uclinux.org, schwab@linux-m68k.org, agraf@suse.de On 05/04/2016 10:11 AM, Laurent Vivier wrote: > + INSN(bkpt, 4848, fff8, M68000); Do we care that this comes in with 68010 not 68000? Otherwise, Reviewed-by: Richard Henderson r~