[Qemu-devel] [PATCH 00/16] target/xtensa updates

[Qemu-devel] [PATCH 00/16] target/xtensa updates

[Max Filippov]

Hi Peter,

please pull the following batch of updates for the target/xtensa.

The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639:

  Update version for v2.11.0 release (2017-12-13 14:31:09 +0000)

are available in the git repository at:

  git://github.com/OSLL/qemu-xtensa.git tags/20171227-xtensa

for you to fetch changes up to d462b6b6b79f092327927b3fb3ac20505c90a706:

  target/xtensa: implement disassembler (2017-12-18 21:26:20 -0800)

----------------------------------------------------------------
target/xtensa updates:

- add libisa to the xtensa target;
- change xtensa instruction translator to use it;
- switch existing xtensa cores to use it;
- add support for a number of instructions: salt/saltu, const16,
  GPIO32 group, debug mode and MMU-related;
- add disassembler for Xtensa.

----------------------------------------------------------------
Max Filippov (16):
      target/xtensa: pass actual frame size to the entry helper
      target/xtensa: import libisa source
      target/xtensa: extract core opcode translators
      target/xtensa: extract FPU2000 opcode translators
      target/xtensa: update import_core.sh script for libisa
      target/xtensa: switch dc232b to libisa
      target/xtensa: switch dc233c to libisa
      target/xtensa: switch fsf to libisa
      target/xtensa: use libisa for instruction decoding
      target/xtensa: tests: fix memctl SR test
      target/xtensa: drop DisasContext::litbase
      target/xtensa: add internal/noop SRs and opcodes
      target/xtensa: implement salt/saltu
      target/xtensa: implement GPIO32
      target/xtensa: implement const16
      target/xtensa: implement disassembler

 MAINTAINERS                                |     1 +
 disas/Makefile.objs                        |     1 +
 disas/xtensa.c                             |   133 +
 include/disas/bfd.h                        |     1 +
 include/hw/xtensa/xtensa-isa.h             |   838 ++
 target/xtensa/Makefile.objs                |     1 +
 target/xtensa/core-dc232b.c                |     4 +
 target/xtensa/core-dc232b/xtensa-modules.c | 14105 +++++++++++++++++++++++++
 target/xtensa/core-dc233c.c                |     4 +
 target/xtensa/core-dc233c/xtensa-modules.c | 15232 +++++++++++++++++++++++++++
 target/xtensa/core-fsf.c                   |     5 +
 target/xtensa/core-fsf/xtensa-modules.c    |  9841 +++++++++++++++++
 target/xtensa/cpu.c                        |     9 +
 target/xtensa/cpu.h                        |    31 +
 target/xtensa/helper.c                     |    37 +
 target/xtensa/import_core.sh               |    15 +
 target/xtensa/op_helper.c                  |     2 +-
 target/xtensa/translate.c                  |  5883 +++++++----
 target/xtensa/xtensa-isa-internal.h        |   231 +
 target/xtensa/xtensa-isa.c                 |  1745 +++
 target/xtensa/xtensa-isa.h                 |     1 +
 tests/tcg/xtensa/test_sr.S                 |     2 +-
 22 files changed, 45949 insertions(+), 2173 deletions(-)
 create mode 100644 disas/xtensa.c
 create mode 100644 include/hw/xtensa/xtensa-isa.h
 create mode 100644 target/xtensa/core-dc232b/xtensa-modules.c
 create mode 100644 target/xtensa/core-dc233c/xtensa-modules.c
 create mode 100644 target/xtensa/core-fsf/xtensa-modules.c
 create mode 100644 target/xtensa/xtensa-isa-internal.h
 create mode 100644 target/xtensa/xtensa-isa.c
 create mode 100644 target/xtensa/xtensa-isa.h

-- 
2.1.4

Re: [Qemu-devel] [PATCH 00/16] target/xtensa updates

[Peter Maydell]

On 27 December 2017 at 17:46, Max Filippov <jcmvbkbc@gmail.com> wrote:
> Hi Peter,
>
> please pull the following batch of updates for the target/xtensa.
>
> The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639:
>
>   Update version for v2.11.0 release (2017-12-13 14:31:09 +0000)
>
> are available in the git repository at:
>
>   git://github.com/OSLL/qemu-xtensa.git tags/20171227-xtensa
>
> for you to fetch changes up to d462b6b6b79f092327927b3fb3ac20505c90a706:
>
>   target/xtensa: implement disassembler (2017-12-18 21:26:20 -0800)
>
> ----------------------------------------------------------------
> target/xtensa updates:
>
> - add libisa to the xtensa target;
> - change xtensa instruction translator to use it;
> - switch existing xtensa cores to use it;
> - add support for a number of instructions: salt/saltu, const16,
>   GPIO32 group, debug mode and MMU-related;
> - add disassembler for Xtensa.

Hi; I'm afraid this doesn't build on clang:

/home/petmay01/linaro/qemu-for-merges/target/xtensa/translate.c:261:20:
error: unused function 'option_bits_enabled'
[-Werror,-Wunused-function]
static inline bool option_bits_enabled(DisasContext *dc, uint64_t opt)
                   ^
1 error generated.

Probably an easy fix; clang is stricter than gcc about
not liking unused static inline functions in .c files.

thanks
-- PMM