qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin " <mst@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: [Qemu-devel] [PATCH 0/5] tests: acpi: fix FADT not being tested and cleanups
Date: Fri, 29 Dec 2017 16:16:37 +0100	[thread overview]
Message-ID: <1514560602-280058-1-git-send-email-imammedo@redhat.com> (raw)

Even though we have tests/acpi-test-data/[q35|pc]/FACP reference table
in source tree, it hasn't been actually tested. As result it went stale
and we did not notice any changes that were happening to it.

Fix it buy making sure it's not ignored and before fixing it,
do some cleanups in testcase that hopefully will make more clear what
functions actually do. 

NOTE to maintaner:
   after fix in 5/5 update following reference tables, to match reality
   tests/acpi-test-data/pc/FACP
   tests/acpi-test-data/q35/FACP


CC: Michael S. Tsirkin" <mst@redhat.com>
CC: Thomas Huth <thuth@redhat.com>

Igor Mammedov (5):
  tests: acpi: move tested tables array allocation outside of
    test_acpi_dsdt_table()
  tests: acpi: init table descriptor in test_dst_table()
  tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its
    usage
  tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables
    usage
  tests: acpi: fix FADT not being compared to reference table

 tests/bios-tables-test.c | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-12-29 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29 15:16 Igor Mammedov [this message]
2017-12-29 15:16 ` [Qemu-devel] [PATCH 1/5] tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table() Igor Mammedov
2017-12-29 15:16 ` [Qemu-devel] [PATCH 2/5] tests: acpi: init table descriptor in test_dst_table() Igor Mammedov
2017-12-29 15:16 ` [Qemu-devel] [PATCH 3/5] tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its usage Igor Mammedov
2017-12-29 15:16 ` [Qemu-devel] [PATCH 4/5] tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables usage Igor Mammedov
2017-12-29 15:16 ` [Qemu-devel] [PATCH 5/5] tests: acpi: fix FADT not being compared to reference table Igor Mammedov
2018-01-16  4:16   ` Michael S. Tsirkin
2018-01-16 13:17     ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514560602-280058-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).