From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf28j-0004a1-W8 for qemu-devel@nongnu.org; Wed, 22 May 2013 02:03:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uf28i-0001cI-Av for qemu-devel@nongnu.org; Wed, 22 May 2013 02:03:09 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:42799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf28i-0001Zl-3W for qemu-devel@nongnu.org; Wed, 22 May 2013 02:03:08 -0400 Date: Wed, 22 May 2013 02:03:05 -0400 (EDT) From: Paolo Bonzini Message-ID: <1514690342.5631967.1369202585862.JavaMail.root@redhat.com> In-Reply-To: <926326e96fd8685d74e9d5bf430fe4ad97a55289.1369191585.git.peter.crosthwaite@xilinx.com> References: <926326e96fd8685d74e9d5bf430fe4ad97a55289.1369191585.git.peter.crosthwaite@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1 1/1] glib: Fix some misuses of gsize/size_t types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter crosthwaite Cc: edgar iglesias , aliguori@us.ibm.com, qemu-devel@nongnu.org, qemu-trival@nongnu.org ----- Messaggio originale ----- > Da: "peter crosthwaite" > A: qemu-devel@nongnu.org > Cc: pbonzini@redhat.com, aliguori@us.ibm.com, "edgar iglesias" > Inviato: Mercoled=C3=AC, 22 maggio 2013 5:01:43 > Oggetto: [PATCH v1 1/1] glib: Fix some misuses of gsize/size_t types >=20 > From: Peter Crosthwaite >=20 > This unbreaks cross compile builds: >=20 > configure --target-list=3D"i386-softmmu" --cpu=3Di386 >=20 > When building on a 64bit machine. >=20 > Reported-by: David Holsgrove > Signed-off-by: Peter Crosthwaite > --- >=20 > hw/nvram/fw_cfg.c | 4 ++-- > qemu-char.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index 1a7e49c..479113b 100644 > --- a/hw/nvram/fw_cfg.c > +++ b/hw/nvram/fw_cfg.c > @@ -54,7 +54,7 @@ struct FWCfgState { > #define JPG_FILE 0 > #define BMP_FILE 1 > =20 > -static char *read_splashfile(char *filename, size_t *file_sizep, > +static char *read_splashfile(char *filename, gsize *file_sizep, > int *file_typep) > { > GError *err =3D NULL; > @@ -112,7 +112,7 @@ static void fw_cfg_bootsplash(FWCfgState *s) > const char *boot_splash_filename =3D NULL; > char *p; > char *filename, *file_data; > - size_t file_size; > + gsize file_size; > int file_type; > const char *temp; > =20 > diff --git a/qemu-char.c b/qemu-char.c > index cff2896..5d20d3c 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -2920,7 +2920,7 @@ void qmp_ringbuf_write(const char *device, const ch= ar > *data, > CharDriverState *chr; > const uint8_t *write_data; > int ret; > - size_t write_count; > + gsize write_count; > =20 > chr =3D qemu_chr_find(device); > if (!chr) { > -- > 1.8.3.rc1.44.gb387c77.dirty >=20 >=20 Adding qemu-trivial... Reviewed-by: Paolo Bonzini Paolo