* [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator
@ 2018-01-08 17:10 Peter Maydell
2018-01-08 17:15 ` Eric Blake
2018-01-08 17:16 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Peter Maydell @ 2018-01-08 17:10 UTC (permalink / raw)
To: qemu-devel
Cc: patches, Philippe Mathieu-Daudé, Paolo Bonzini,
Sergio Andres Gomez Del Real
In commit c97d6d2cdf97ed we accidentally added code to configure
that uses '==' for string equality testing. This is a bashism --
the portable way to write this is '='.
This fixes the "Unexpected operator error" complaint produced
if the system /bin/sh is dash.
Fixes: c97d6d2cdf97ed
Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
As an aside, it's annoying that this doesn't make configure fail;
otherwise it wouldn't have got through my build tests.
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 56f9716..6a04082 100755
--- a/configure
+++ b/configure
@@ -5076,7 +5076,7 @@ fi
#################################################
# Check to see if we have the Hypervisor framework
-if [ "$darwin" == "yes" ] ; then
+if [ "$darwin" = "yes" ] ; then
cat > $TMPC << EOF
#include <Hypervisor/hv.h>
int main() { return 0;}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator
2018-01-08 17:10 [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator Peter Maydell
@ 2018-01-08 17:15 ` Eric Blake
2018-01-08 17:16 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Eric Blake @ 2018-01-08 17:15 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Sergio Andres Gomez Del Real, Paolo Bonzini,
Philippe Mathieu-Daudé, patches
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On 01/08/2018 11:10 AM, Peter Maydell wrote:
> In commit c97d6d2cdf97ed we accidentally added code to configure
> that uses '==' for string equality testing. This is a bashism --
> the portable way to write this is '='.
>
> This fixes the "Unexpected operator error" complaint produced
> if the system /bin/sh is dash.
>
> Fixes: c97d6d2cdf97ed
> Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> As an aside, it's annoying that this doesn't make configure fail;
> otherwise it wouldn't have got through my build tests.
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator
2018-01-08 17:10 [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator Peter Maydell
2018-01-08 17:15 ` Eric Blake
@ 2018-01-08 17:16 ` Philippe Mathieu-Daudé
2018-01-08 21:01 ` Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-01-08 17:16 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Sergio Andres Gomez Del Real, Paolo Bonzini, patches
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On 01/08/2018 02:10 PM, Peter Maydell wrote:
> In commit c97d6d2cdf97ed we accidentally added code to configure
> that uses '==' for string equality testing. This is a bashism --
> the portable way to write this is '='.
>
> This fixes the "Unexpected operator error" complaint produced
> if the system /bin/sh is dash.
Thanks :)
>
> Fixes: c97d6d2cdf97ed
> Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> As an aside, it's annoying that this doesn't make configure fail;
> otherwise it wouldn't have got through my build tests.
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 56f9716..6a04082 100755
> --- a/configure
> +++ b/configure
> @@ -5076,7 +5076,7 @@ fi
>
> #################################################
> # Check to see if we have the Hypervisor framework
> -if [ "$darwin" == "yes" ] ; then
> +if [ "$darwin" = "yes" ] ; then
> cat > $TMPC << EOF
> #include <Hypervisor/hv.h>
> int main() { return 0;}
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator
2018-01-08 17:16 ` Philippe Mathieu-Daudé
@ 2018-01-08 21:01 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2018-01-08 21:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Developers, Sergio Andres Gomez Del Real, Paolo Bonzini,
patches@linaro.org
On 8 January 2018 at 17:16, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 01/08/2018 02:10 PM, Peter Maydell wrote:
>> In commit c97d6d2cdf97ed we accidentally added code to configure
>> that uses '==' for string equality testing. This is a bashism --
>> the portable way to write this is '='.
>>
>> This fixes the "Unexpected operator error" complaint produced
>> if the system /bin/sh is dash.
>
> Thanks :)
>
>>
>> Fixes: c97d6d2cdf97ed
>> Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-08 21:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-08 17:10 [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator Peter Maydell
2018-01-08 17:15 ` Eric Blake
2018-01-08 17:16 ` Philippe Mathieu-Daudé
2018-01-08 21:01 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).