From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PULL 52/52] scripts/analyse-locks-simpletrace.py: script to analyse lock times
Date: Fri, 12 Jan 2018 12:31:16 +0100 [thread overview]
Message-ID: <1515756676-3860-53-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1515756676-3860-1-git-send-email-pbonzini@redhat.com>
From: Alex Bennée <alex.bennee@linaro.org>
This script allows analysis of mutex acquisition and hold times based
on a trace file. Given a trace control file of:
qemu_mutex_lock
qemu_mutex_locked
qemu_mutex_unlock
And running with:
$QEMU $QEMU_ARGS -trace events=./lock-trace
You can analyse the results with:
./scripts/analyse-locks-simpletrace.py trace-events-all ./trace-21812
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/analyse-locks-simpletrace.py | 99 ++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
create mode 100755 scripts/analyse-locks-simpletrace.py
diff --git a/scripts/analyse-locks-simpletrace.py b/scripts/analyse-locks-simpletrace.py
new file mode 100755
index 0000000..a69ed5c
--- /dev/null
+++ b/scripts/analyse-locks-simpletrace.py
@@ -0,0 +1,99 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+#
+# Analyse lock events and
+#
+# Author: Alex Bennée <alex.bennee@linaro.org>
+#
+
+import os
+import simpletrace
+import argparse
+import numpy as np
+
+class MutexAnalyser(simpletrace.Analyzer):
+ "A simpletrace Analyser for checking locks."
+
+ def __init__(self):
+ self.locks = 0
+ self.locked = 0
+ self.unlocks = 0
+ self.mutex_records = {}
+
+ def _get_mutex(self, mutex):
+ if not mutex in self.mutex_records:
+ self.mutex_records[mutex] = {"locks": 0,
+ "lock_time": 0,
+ "acquire_times": [],
+ "locked": 0,
+ "locked_time": 0,
+ "held_times": [],
+ "unlocked": 0}
+
+ return self.mutex_records[mutex]
+
+ def qemu_mutex_lock(self, timestamp, mutex, filename, line):
+ self.locks += 1
+ rec = self._get_mutex(mutex)
+ rec["locks"] += 1
+ rec["lock_time"] = timestamp[0]
+ rec["lock_loc"] = (filename, line)
+
+ def qemu_mutex_locked(self, timestamp, mutex, filename, line):
+ self.locked += 1
+ rec = self._get_mutex(mutex)
+ rec["locked"] += 1
+ rec["locked_time"] = timestamp[0]
+ acquire_time = rec["locked_time"] - rec["lock_time"]
+ rec["locked_loc"] = (filename, line)
+ rec["acquire_times"].append(acquire_time)
+
+ def qemu_mutex_unlock(self, timestamp, mutex, filename, line):
+ self.unlocks += 1
+ rec = self._get_mutex(mutex)
+ rec["unlocked"] += 1
+ held_time = timestamp[0] - rec["locked_time"]
+ rec["held_times"].append(held_time)
+ rec["unlock_loc"] = (filename, line)
+
+
+def get_args():
+ "Grab options"
+ parser = argparse.ArgumentParser()
+ parser.add_argument("--output", "-o", type=str, help="Render plot to file")
+ parser.add_argument("events", type=str, help='trace file read from')
+ parser.add_argument("tracefile", type=str, help='trace file read from')
+ return parser.parse_args()
+
+if __name__ == '__main__':
+ args = get_args()
+
+ # Gather data from the trace
+ analyser = MutexAnalyser()
+ simpletrace.process(args.events, args.tracefile, analyser)
+
+ print ("Total locks: %d, locked: %d, unlocked: %d" %
+ (analyser.locks, analyser.locked, analyser.unlocks))
+
+ # Now dump the individual lock stats
+ for key, val in sorted(analyser.mutex_records.iteritems(),
+ key=lambda (k,v): v["locks"]):
+ print ("Lock: %#x locks: %d, locked: %d, unlocked: %d" %
+ (key, val["locks"], val["locked"], val["unlocked"]))
+
+ acquire_times = np.array(val["acquire_times"])
+ if len(acquire_times) > 0:
+ print (" Acquire Time: min:%d median:%d avg:%.2f max:%d" %
+ (acquire_times.min(), np.median(acquire_times),
+ acquire_times.mean(), acquire_times.max()))
+
+ held_times = np.array(val["held_times"])
+ if len(held_times) > 0:
+ print (" Held Time: min:%d median:%d avg:%.2f max:%d" %
+ (held_times.min(), np.median(held_times),
+ held_times.mean(), held_times.max()))
+
+ # Check if any locks still held
+ if val["locks"] > val["locked"]:
+ print (" LOCK HELD (%s:%s)" % (val["locked_loc"]))
+ print (" BLOCKED (%s:%s)" % (val["lock_loc"]))
--
1.8.3.1
next prev parent reply other threads:[~2018-01-12 11:32 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 11:30 [Qemu-devel] [PULL 00/52] Misc patches for 2017-01-12 Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 01/52] scsi-generic: Add share-rw option Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 02/52] scsi: fix scsi_convert_sense crash when in_buf == NULL && in_len == 0 Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 03/52] pc: fail memory hot-plug/unplug with -no-acpi and Q35 machine type Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 04/52] hpet: recover timer offset correctly Paolo Bonzini
2018-01-12 11:47 ` Pavel Dovgalyuk
2018-01-12 12:08 ` Paolo Bonzini
2018-01-12 12:18 ` Pavel Dovgalyuk
2018-01-12 12:21 ` Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 05/52] i386/cpu/kvm: look at PMU's CPUID before setting MSRs Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 06/52] chardev: use backend chr context when watch for fe Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 07/52] chardev: let g_idle_add() be with chardev gcontext Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 08/52] chardev: introduce qemu_chr_timeout_add_ms() Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 09/52] build-sys: fix qemu-ga -pthread linking Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 10/52] build-sys: silence make by default or V=0 Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 11/52] build-sys: add a rule to print a variable Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 12/52] build-sys: compile with -Og or -O1 when --enable-debug Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 13/52] tests/docker: add some sanitizers to fedora dockerfile Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 14/52] tests/docker: add test-debug Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 15/52] build-sys: add some sanitizers when --enable-debug if possible Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 16/52] tests: fix check-qobject leak Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 17/52] vl: fix direct firmware directories leak Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 18/52] readline: add a free function Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 19/52] tests: fix migration-test leak Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 20/52] crypto: fix stack-buffer-overflow error Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 21/52] qemu-config: fix leak in query-command-line-options Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 22/52] tests: fix qmp-test leak Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 23/52] ucontext: annotate coroutine stack for ASAN Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 24/52] tests: fix coroutine leak in /basic/entered Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 25/52] mips: fix potential fopen(NULL,...) Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 26/52] disas/s390: fix global-buffer-overflow Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 27/52] scsi-disk: release AioContext in unaligned WRITE SAME case Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 28/52] tests/boot-serial-test: Add tests for microblaze boards Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 29/52] tests/boot-serial-test: Add a test for the moxiesim machine Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 30/52] tests/boot-serial-test: Add support for the raspi2 machine Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 31/52] target/i386: move hflags update code to a function Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 32/52] target/i386: hax: change to use x86_update_hflags Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 33/52] target/i386: hax: Move x86_update_hflags Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 34/52] target-i386: update hflags on Hypervisor.framework Paolo Bonzini
2018-01-12 11:30 ` [Qemu-devel] [PULL 35/52] scripts/qemu-gdb: add simple tcg lock status helper Paolo Bonzini
2018-01-12 12:37 ` Alex Bennée
2018-01-12 11:31 ` [Qemu-devel] [PULL 36/52] scripts/qemu-gdb/timers.py: new helper to dump timer state Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 37/52] icount: fixed saving/restoring of icount warp timers Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 38/52] cpus: unify qemu_*_wait_io_event Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 39/52] irq: fix memory leak Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 40/52] net: Drop unusual use of do { } while (0); Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 41/52] mips: Tweak location of ';' in macros Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 42/52] chardev: Use goto/label instead of do/break/while(0) Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 43/52] chardev: Clean up previous patch indentation Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 44/52] tests: Avoid 'do/while(false); ' in vhost-user-bridge Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 45/52] maint: Fix macros with broken 'do/while(0); ' usage Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 46/52] checkpatch: Enforce proper do/while (0) style Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 47/52] find_ram_offset: Add comments and tracing Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 48/52] find_ram_offset: Align ram_addr_t allocation on long boundaries Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 49/52] block/iscsi: fix initialization of iTask in iscsi_co_get_block_status Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 50/52] cpu: flush TB cache when loading VMState Paolo Bonzini
2018-01-12 11:31 ` [Qemu-devel] [PULL 51/52] util/qemu-thread-*: add qemu_lock, locked and unlock trace events Paolo Bonzini
2018-01-12 11:31 ` Paolo Bonzini [this message]
2018-01-12 18:38 ` [Qemu-devel] [PULL 52/52] scripts/analyse-locks-simpletrace.py: script to analyse lock times Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515756676-3860-53-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).