From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gal Hammer <ghammer@redhat.com>, Stefan Weil <sw@weilnetz.de>
Subject: [Qemu-devel] [PULL 06/33] qemu: add a cleanup callback function to EventNotifier
Date: Tue, 16 Jan 2018 06:46:56 +0200 [thread overview]
Message-ID: <1516077852-7974-7-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1516077852-7974-1-git-send-email-mst@redhat.com>
From: Gal Hammer <ghammer@redhat.com>
Adding a cleanup callback function to the EventNotifier struct
which allows users to execute event_notifier_cleanup in a
different context.
Signed-off-by: Gal Hammer <ghammer@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/qemu/event_notifier.h | 1 +
util/event_notifier-posix.c | 5 ++++-
util/event_notifier-win32.c | 2 ++
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/qemu/event_notifier.h b/include/qemu/event_notifier.h
index 599c99f..b30a454 100644
--- a/include/qemu/event_notifier.h
+++ b/include/qemu/event_notifier.h
@@ -26,6 +26,7 @@ struct EventNotifier {
int rfd;
int wfd;
#endif
+ void (*cleanup)(EventNotifier *);
};
typedef void EventNotifierHandler(EventNotifier *);
diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c
index 73c4046..6525666 100644
--- a/util/event_notifier-posix.c
+++ b/util/event_notifier-posix.c
@@ -29,6 +29,7 @@ void event_notifier_init_fd(EventNotifier *e, int fd)
{
e->rfd = fd;
e->wfd = fd;
+ e->cleanup = NULL;
}
#endif
@@ -65,6 +66,7 @@ int event_notifier_init(EventNotifier *e, int active)
e->rfd = fds[0];
e->wfd = fds[1];
}
+ e->cleanup = NULL;
if (active) {
event_notifier_set(e);
}
@@ -80,10 +82,11 @@ void event_notifier_cleanup(EventNotifier *e)
{
if (e->rfd != e->wfd) {
close(e->rfd);
- e->rfd = -1;
}
close(e->wfd);
+ e->rfd = -1;
e->wfd = -1;
+ e->cleanup = NULL;
}
int event_notifier_get_fd(const EventNotifier *e)
diff --git a/util/event_notifier-win32.c b/util/event_notifier-win32.c
index 62c53b0..eff8670 100644
--- a/util/event_notifier-win32.c
+++ b/util/event_notifier-win32.c
@@ -19,6 +19,7 @@ int event_notifier_init(EventNotifier *e, int active)
{
e->event = CreateEvent(NULL, TRUE, FALSE, NULL);
assert(e->event);
+ e->cleanup = NULL;
return 0;
}
@@ -26,6 +27,7 @@ void event_notifier_cleanup(EventNotifier *e)
{
CloseHandle(e->event);
e->event = NULL;
+ e->cleanup = NULL;
}
HANDLE event_notifier_get_handle(EventNotifier *e)
--
MST
next prev parent reply other threads:[~2018-01-16 4:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 4:46 [Qemu-devel] [PULL 00/33] pc, pci, virtio: features, fixes, cleanups Michael S. Tsirkin
2018-01-16 4:46 ` [Qemu-devel] [PULL 01/33] MAINTAINERS: Add myself as maintainer to X86 machines Michael S. Tsirkin
2018-01-16 5:55 ` Thomas Huth
2018-01-16 4:46 ` [Qemu-devel] [PULL 02/33] vhost-user: add new vhost user messages to support virtio config space Michael S. Tsirkin
2018-01-16 4:46 ` [Qemu-devel] [PULL 03/33] vhost-user-blk: introduce a new vhost-user-blk host device Michael S. Tsirkin
2018-01-16 4:46 ` [Qemu-devel] [PULL 04/33] contrib/libvhost-user: enable virtio config space messages Michael S. Tsirkin
2018-01-16 4:46 ` [Qemu-devel] [PULL 05/33] contrib/vhost-user-blk: introduce a vhost-user-blk sample application Michael S. Tsirkin
2018-01-16 4:46 ` Michael S. Tsirkin [this message]
2018-01-16 4:46 ` [Qemu-devel] [PULL 07/33] virtio: postpone the execution of event_notifier_cleanup function Michael S. Tsirkin
2018-01-16 4:46 ` [Qemu-devel] [PULL 08/33] virtio: improve virtio devices initialization time Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 09/33] pci/shpc: Move function to generic header file Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 10/33] vhost-user: fix multiple queue specification Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 11/33] intel-iommu: Redefine macros to enable supporting 48 bit address width Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 12/33] intel-iommu: Extend address width to 48 bits Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 13/33] hw/pci-bridge: fix QEMU crash because of pcie-root-port Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 14/33] ACPI/unit-test: Add a testcase for RAM allocation in numa node Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 15/33] hw/acpi-build: Make next_base easy to follow Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 16/33] vhost-user-test: fix features mask Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 17/33] vhost-user-test: extract read-guest-mem test from main loop Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 18/33] vhost-user-test: setup virtqueues in all tests Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 19/33] vhost-user-test: make features mask an init_virtio_dev() argument Michael S. Tsirkin
2018-01-16 4:47 ` [Qemu-devel] [PULL 20/33] vhost-user-test: use init_virtio_dev in multiqueue test Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 21/33] vhost: Build temporary section list and deref after commit Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 22/33] vhost: Move log_dirty check Michael S. Tsirkin
2018-01-16 13:27 ` Igor Mammedov
2018-01-16 4:48 ` [Qemu-devel] [PULL 23/33] vhost: Simplify ring verification checks Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 24/33] vhost: Merge sections added to temporary list Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 25/33] x86_iommu: Move machine check to x86_iommu_realize() Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 26/33] x86_iommu: check if machine has PCI bus Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 27/33] tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table() Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 28/33] tests: acpi: init table descriptor in test_dst_table() Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 29/33] tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its usage Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 30/33] tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables usage Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 31/33] vhost-user: factor out msg head and payload Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 32/33] vhost-user: fix misaligned access to payload Michael S. Tsirkin
2018-01-16 4:48 ` [Qemu-devel] [PULL 33/33] vhost: remove assertion to prevent crash Michael S. Tsirkin
2018-01-16 12:24 ` [Qemu-devel] [PULL 00/33] pc, pci, virtio: features, fixes, cleanups Peter Maydell
2018-01-16 12:58 ` Peter Maydell
2018-01-16 12:59 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516077852-7974-7-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=ghammer@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).