From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
eblake@redhat.com, den@virtuozzo.com, berto@igalia.com,
Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v6 7/9] qcow2: move is_zero() up
Date: Tue, 16 Jan 2018 16:04:28 +0300 [thread overview]
Message-ID: <1516107870-8110-8-git-send-email-anton.nefedov@virtuozzo.com> (raw)
In-Reply-To: <1516107870-8110-1-git-send-email-anton.nefedov@virtuozzo.com>
To be used in the following commit without a forward declaration.
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
block/qcow2.c | 35 +++++++++++++++++------------------
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 4348b2c..2ed21ff 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1858,6 +1858,23 @@ static bool merge_cow(uint64_t offset, unsigned bytes,
return false;
}
+static bool is_zero(BlockDriverState *bs, int64_t offset, int64_t bytes)
+{
+ int64_t nr;
+ int res;
+
+ /* Clamp to image length, before checking status of underlying sectors */
+ if (offset + bytes > bs->total_sectors * BDRV_SECTOR_SIZE) {
+ bytes = bs->total_sectors * BDRV_SECTOR_SIZE - offset;
+ }
+
+ if (!bytes) {
+ return true;
+ }
+ res = bdrv_block_status_above(bs, NULL, offset, bytes, &nr, NULL, NULL);
+ return res >= 0 && (res & BDRV_BLOCK_ZERO) && nr == bytes;
+}
+
static coroutine_fn int qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,
uint64_t bytes, QEMUIOVector *qiov,
int flags)
@@ -2975,24 +2992,6 @@ finish:
return ret;
}
-
-static bool is_zero(BlockDriverState *bs, int64_t offset, int64_t bytes)
-{
- int64_t nr;
- int res;
-
- /* Clamp to image length, before checking status of underlying sectors */
- if (offset + bytes > bs->total_sectors * BDRV_SECTOR_SIZE) {
- bytes = bs->total_sectors * BDRV_SECTOR_SIZE - offset;
- }
-
- if (!bytes) {
- return true;
- }
- res = bdrv_block_status_above(bs, NULL, offset, bytes, &nr, NULL, NULL);
- return res >= 0 && (res & BDRV_BLOCK_ZERO) && nr == bytes;
-}
-
static coroutine_fn int qcow2_co_pwrite_zeroes(BlockDriverState *bs,
int64_t offset, int bytes, BdrvRequestFlags flags)
{
--
2.7.4
next prev parent reply other threads:[~2018-01-16 13:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 13:04 [Qemu-devel] [PATCH v6 0/9] qcow2: cluster space preallocation Anton Nefedov
2018-01-16 13:04 ` [Qemu-devel] [PATCH v6 1/9] mirror: inherit supported write/zero flags Anton Nefedov
2018-01-16 13:04 ` [Qemu-devel] [PATCH v6 2/9] blkverify: set " Anton Nefedov
2018-01-16 13:04 ` [Qemu-devel] [PATCH v6 3/9] block: introduce BDRV_REQ_ALLOCATE flag Anton Nefedov
2018-01-16 13:04 ` [Qemu-devel] [PATCH v6 4/9] block: treat BDRV_REQ_ALLOCATE as serialising Anton Nefedov
2018-01-16 20:43 ` Eric Blake
2018-01-16 13:04 ` [Qemu-devel] [PATCH v6 5/9] file-posix: support BDRV_REQ_ALLOCATE Anton Nefedov
2018-01-16 13:04 ` [Qemu-devel] [PATCH v6 6/9] block: support BDRV_REQ_ALLOCATE in passthrough drivers Anton Nefedov
2018-01-16 13:04 ` Anton Nefedov [this message]
2018-01-16 13:04 ` [Qemu-devel] [PATCH v6 8/9] qcow2: skip writing zero buffers to empty COW areas Anton Nefedov
2018-01-16 16:11 ` Alberto Garcia
2018-01-17 14:12 ` Anton Nefedov
2018-01-16 13:04 ` [Qemu-devel] [PATCH v6 9/9] iotest 134: test cluster-misaligned encrypted write Anton Nefedov
2018-01-16 20:45 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516107870-8110-8-git-send-email-anton.nefedov@virtuozzo.com \
--to=anton.nefedov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).