qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Dou Liyang <douly.fnst@cn.fujitsu.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL v2 15/34] hw/acpi-build: Make next_base easy to follow
Date: Tue, 16 Jan 2018 19:50:01 +0200	[thread overview]
Message-ID: <1516121887-32738-16-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1516121887-32738-1-git-send-email-mst@redhat.com>

From: Dou Liyang <douly.fnst@cn.fujitsu.com>

It may be hard to read the assignment statement of "next_base", so

S/next_base += (1ULL << 32) - pcms->below_4g_mem_size;
 /next_base = mem_base + mem_len;

... for readability.

No functionality change.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/i386/acpi-build.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 6f38fb9..dc4b2b9 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -2394,7 +2394,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
             }
             mem_base = 1ULL << 32;
             mem_len = next_base - pcms->below_4g_mem_size;
-            next_base += (1ULL << 32) - pcms->below_4g_mem_size;
+            next_base = mem_base + mem_len;
         }
         numamem = acpi_data_push(table_data, sizeof *numamem);
         build_srat_memory(numamem, mem_base, mem_len, i - 1,
-- 
MST

  parent reply	other threads:[~2018-01-16 17:50 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 17:46 [Qemu-devel] [PULL v2 00/34] pc, pci, virtio: features, fixes, cleanups Michael S. Tsirkin
2018-01-16 17:46 ` [Qemu-devel] [PULL v2 01/34] MAINTAINERS: Add myself as maintainer to X86 machines Michael S. Tsirkin
2018-01-16 17:47 ` [Qemu-devel] [PULL v2 02/34] vhost-user: add new vhost user messages to support virtio config space Michael S. Tsirkin
2018-01-16 17:47 ` [Qemu-devel] [PULL v2 03/34] vhost-user-blk: introduce a new vhost-user-blk host device Michael S. Tsirkin
2018-01-16 17:48 ` [Qemu-devel] [PULL v2 04/34] contrib/libvhost-user: enable virtio config space messages Michael S. Tsirkin
2018-01-16 17:48 ` [Qemu-devel] [PULL v2 05/34] contrib/vhost-user-blk: introduce a vhost-user-blk sample application Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 06/34] qemu: add a cleanup callback function to EventNotifier Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 07/34] virtio: postpone the execution of event_notifier_cleanup function Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 08/34] virtio: improve virtio devices initialization time Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 09/34] pci/shpc: Move function to generic header file Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 10/34] vhost-user: fix multiple queue specification Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 11/34] intel-iommu: Redefine macros to enable supporting 48 bit address width Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 12/34] intel-iommu: Extend address width to 48 bits Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 13/34] hw/pci-bridge: fix QEMU crash because of pcie-root-port Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 14/34] ACPI/unit-test: Add a testcase for RAM allocation in numa node Michael S. Tsirkin
2018-01-16 17:50 ` Michael S. Tsirkin [this message]
2018-01-16 17:50 ` [Qemu-devel] [PULL v2 16/34] vhost-user-test: fix features mask Michael S. Tsirkin
2018-01-16 17:50 ` [Qemu-devel] [PULL v2 17/34] vhost-user-test: extract read-guest-mem test from main loop Michael S. Tsirkin
2018-01-16 17:50 ` [Qemu-devel] [PULL v2 18/34] vhost-user-test: setup virtqueues in all tests Michael S. Tsirkin
2018-01-16 17:51 ` [Qemu-devel] [PULL v2 19/34] vhost-user-test: make features mask an init_virtio_dev() argument Michael S. Tsirkin
2018-01-16 17:51 ` [Qemu-devel] [PULL v2 20/34] vhost-user-test: use init_virtio_dev in multiqueue test Michael S. Tsirkin
2018-01-16 17:51 ` [Qemu-devel] [PULL v2 21/34] vhost: Build temporary section list and deref after commit Michael S. Tsirkin
2018-01-16 17:51 ` [Qemu-devel] [PULL v2 22/34] vhost: Simplify ring verification checks Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 23/34] vhost: Merge sections added to temporary list Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 24/34] x86_iommu: Move machine check to x86_iommu_realize() Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 25/34] x86_iommu: check if machine has PCI bus Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 26/34] tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table() Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 27/34] tests: acpi: init table descriptor in test_dst_table() Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 28/34] tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its usage Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 29/34] tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables usage Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 30/34] vhost-user: factor out msg head and payload Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 31/34] vhost-user: fix misaligned access to payload Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 32/34] vhost: remove assertion to prevent crash Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 33/34] vhost: fix memslot limit check Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 34/34] vhost: used_memslots refactoring Michael S. Tsirkin
2018-01-18 10:09 ` [Qemu-devel] [PULL v2 00/34] pc, pci, virtio: features, fixes, cleanups Peter Maydell
2018-01-18 19:30   ` Michael S. Tsirkin
2018-01-19 10:13     ` Peter Maydell
2018-01-18 20:48   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516121887-32738-16-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).