From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Eric Blake" <eblake@redhat.com>
Subject: [Qemu-devel] [PULL v2 19/34] vhost-user-test: make features mask an init_virtio_dev() argument
Date: Tue, 16 Jan 2018 19:51:14 +0200 [thread overview]
Message-ID: <1516121887-32738-20-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1516121887-32738-1-git-send-email-mst@redhat.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
The goal is to generalize the use of [un]init_virtio_dev() to
all tests, which does not necessarily expose the same features
set.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/vhost-user-test.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index 969e393..6a144e8 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -164,7 +164,7 @@ typedef struct TestServer {
static const char *tmpfs;
static const char *root;
-static void init_virtio_dev(TestServer *s)
+static void init_virtio_dev(TestServer *s, uint32_t features_mask)
{
uint32_t features;
int i;
@@ -187,7 +187,7 @@ static void init_virtio_dev(TestServer *s)
}
features = qvirtio_get_features(&s->dev->vdev);
- features = features & (1u << VIRTIO_NET_F_MAC);
+ features = features & features_mask;
qvirtio_set_features(&s->dev->vdev, features);
qvirtio_set_driver_ok(&s->dev->vdev);
@@ -652,7 +652,7 @@ static void test_read_guest_mem(void)
s = qtest_start(qemu_cmd);
g_free(qemu_cmd);
- init_virtio_dev(server);
+ init_virtio_dev(server, 1u << VIRTIO_NET_F_MAC);
read_guest_mem(server);
@@ -681,7 +681,7 @@ static void test_migrate(void)
from = qtest_start(cmd);
g_free(cmd);
- init_virtio_dev(s);
+ init_virtio_dev(s, 1u << VIRTIO_NET_F_MAC);
wait_for_fds(s);
size = get_log_size(s);
g_assert_cmpint(size, ==, (2 * 1024 * 1024) / (VHOST_LOG_PAGE * 8));
@@ -803,7 +803,7 @@ static void test_reconnect_subprocess(void)
qtest_start(cmd);
g_free(cmd);
- init_virtio_dev(s);
+ init_virtio_dev(s, 1u << VIRTIO_NET_F_MAC);
wait_for_fds(s);
wait_for_rings_started(s, 2);
@@ -841,7 +841,7 @@ static void test_connect_fail_subprocess(void)
qtest_start(cmd);
g_free(cmd);
- init_virtio_dev(s);
+ init_virtio_dev(s, 1u << VIRTIO_NET_F_MAC);
wait_for_fds(s);
wait_for_rings_started(s, 2);
@@ -871,7 +871,7 @@ static void test_flags_mismatch_subprocess(void)
qtest_start(cmd);
g_free(cmd);
- init_virtio_dev(s);
+ init_virtio_dev(s, 1u << VIRTIO_NET_F_MAC);
wait_for_fds(s);
wait_for_rings_started(s, 2);
--
MST
next prev parent reply other threads:[~2018-01-16 17:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 17:46 [Qemu-devel] [PULL v2 00/34] pc, pci, virtio: features, fixes, cleanups Michael S. Tsirkin
2018-01-16 17:46 ` [Qemu-devel] [PULL v2 01/34] MAINTAINERS: Add myself as maintainer to X86 machines Michael S. Tsirkin
2018-01-16 17:47 ` [Qemu-devel] [PULL v2 02/34] vhost-user: add new vhost user messages to support virtio config space Michael S. Tsirkin
2018-01-16 17:47 ` [Qemu-devel] [PULL v2 03/34] vhost-user-blk: introduce a new vhost-user-blk host device Michael S. Tsirkin
2018-01-16 17:48 ` [Qemu-devel] [PULL v2 04/34] contrib/libvhost-user: enable virtio config space messages Michael S. Tsirkin
2018-01-16 17:48 ` [Qemu-devel] [PULL v2 05/34] contrib/vhost-user-blk: introduce a vhost-user-blk sample application Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 06/34] qemu: add a cleanup callback function to EventNotifier Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 07/34] virtio: postpone the execution of event_notifier_cleanup function Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 08/34] virtio: improve virtio devices initialization time Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 09/34] pci/shpc: Move function to generic header file Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 10/34] vhost-user: fix multiple queue specification Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 11/34] intel-iommu: Redefine macros to enable supporting 48 bit address width Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 12/34] intel-iommu: Extend address width to 48 bits Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 13/34] hw/pci-bridge: fix QEMU crash because of pcie-root-port Michael S. Tsirkin
2018-01-16 17:49 ` [Qemu-devel] [PULL v2 14/34] ACPI/unit-test: Add a testcase for RAM allocation in numa node Michael S. Tsirkin
2018-01-16 17:50 ` [Qemu-devel] [PULL v2 15/34] hw/acpi-build: Make next_base easy to follow Michael S. Tsirkin
2018-01-16 17:50 ` [Qemu-devel] [PULL v2 16/34] vhost-user-test: fix features mask Michael S. Tsirkin
2018-01-16 17:50 ` [Qemu-devel] [PULL v2 17/34] vhost-user-test: extract read-guest-mem test from main loop Michael S. Tsirkin
2018-01-16 17:50 ` [Qemu-devel] [PULL v2 18/34] vhost-user-test: setup virtqueues in all tests Michael S. Tsirkin
2018-01-16 17:51 ` Michael S. Tsirkin [this message]
2018-01-16 17:51 ` [Qemu-devel] [PULL v2 20/34] vhost-user-test: use init_virtio_dev in multiqueue test Michael S. Tsirkin
2018-01-16 17:51 ` [Qemu-devel] [PULL v2 21/34] vhost: Build temporary section list and deref after commit Michael S. Tsirkin
2018-01-16 17:51 ` [Qemu-devel] [PULL v2 22/34] vhost: Simplify ring verification checks Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 23/34] vhost: Merge sections added to temporary list Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 24/34] x86_iommu: Move machine check to x86_iommu_realize() Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 25/34] x86_iommu: check if machine has PCI bus Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 26/34] tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table() Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 27/34] tests: acpi: init table descriptor in test_dst_table() Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 28/34] tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its usage Michael S. Tsirkin
2018-01-16 17:52 ` [Qemu-devel] [PULL v2 29/34] tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables usage Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 30/34] vhost-user: factor out msg head and payload Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 31/34] vhost-user: fix misaligned access to payload Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 32/34] vhost: remove assertion to prevent crash Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 33/34] vhost: fix memslot limit check Michael S. Tsirkin
2018-01-16 17:53 ` [Qemu-devel] [PULL v2 34/34] vhost: used_memslots refactoring Michael S. Tsirkin
2018-01-18 10:09 ` [Qemu-devel] [PULL v2 00/34] pc, pci, virtio: features, fixes, cleanups Peter Maydell
2018-01-18 19:30 ` Michael S. Tsirkin
2018-01-19 10:13 ` Peter Maydell
2018-01-18 20:48 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516121887-32738-20-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).