qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: minyard@acm.org
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>
Subject: [Qemu-devel] [PATCH 2/7] ipmi: Fix SEL get/set time commands
Date: Thu,  1 Feb 2018 12:52:57 -0600	[thread overview]
Message-ID: <1517511182-9944-3-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1517511182-9944-1-git-send-email-minyard@acm.org>

From: Corey Minyard <cminyard@mvista.com>

The minimum message size was on the wrong commands, for getting
the time it's zero and for setting the time it's 6.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/ipmi/ipmi_bmc_sim.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 277c28c..cc068f2 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipmi_bmc_sim.c
@@ -1802,8 +1802,8 @@ static const IPMICmdHandler storage_cmds[] = {
     [IPMI_CMD_GET_SEL_ENTRY] = { get_sel_entry, 8 },
     [IPMI_CMD_ADD_SEL_ENTRY] = { add_sel_entry, 18 },
     [IPMI_CMD_CLEAR_SEL] = { clear_sel, 8 },
-    [IPMI_CMD_GET_SEL_TIME] = { get_sel_time, 6 },
-    [IPMI_CMD_SET_SEL_TIME] = { set_sel_time },
+    [IPMI_CMD_GET_SEL_TIME] = { get_sel_time },
+    [IPMI_CMD_SET_SEL_TIME] = { set_sel_time, 6 },
 };
 
 static const IPMINetfn storage_netfn = {
-- 
2.7.4

  parent reply	other threads:[~2018-02-01 18:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01 18:52 [Qemu-devel] [PULL 0/7] Small IPMI fixes minyard
2018-02-01 18:52 ` [Qemu-devel] [PATCH 1/7] Add maintainer for the IPMI code minyard
2018-02-01 18:52 ` minyard [this message]
2018-02-01 18:52 ` [Qemu-devel] [PATCH 3/7] ipmi: Don't set the timestamp on add events that don't have it minyard
2018-02-01 18:52 ` [Qemu-devel] [PATCH 4/7] ipmi: Add the platform event message command minyard
2018-02-01 18:53 ` [Qemu-devel] [PATCH 5/7] ipmi: Fix macro issues minyard
2018-02-01 18:53 ` [Qemu-devel] [PATCH 6/7] ipmi: disable IRQ and ATN on an external disconnect minyard
2018-02-01 18:53 ` [Qemu-devel] [PATCH 7/7] ipmi: Allow BMC device properties to be set minyard
2018-02-02 14:52 ` [Qemu-devel] [PULL 0/7] Small IPMI fixes Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2018-01-16  0:57 [Qemu-devel] [PATCH v2] " minyard
2018-01-16  0:57 ` [Qemu-devel] [PATCH 2/7] ipmi: Fix SEL get/set time commands minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517511182-9944-3-git-send-email-minyard@acm.org \
    --to=minyard@acm.org \
    --cc=cminyard@mvista.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).