From: minyard@acm.org
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>
Subject: [Qemu-devel] [PATCH 6/7] ipmi: disable IRQ and ATN on an external disconnect
Date: Thu, 1 Feb 2018 12:53:01 -0600 [thread overview]
Message-ID: <1517511182-9944-7-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1517511182-9944-1-git-send-email-minyard@acm.org>
From: Corey Minyard <cminyard@mvista.com>
Otherwise there's no way to clear them without an external command,
and it could lock the OS in the VM if they were stuck.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
hw/ipmi/ipmi_bmc_extern.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
index 8c0535d..bf0b7ee 100644
--- a/hw/ipmi/ipmi_bmc_extern.c
+++ b/hw/ipmi/ipmi_bmc_extern.c
@@ -425,6 +425,11 @@ static void chr_event(void *opaque, int event)
return;
}
ibe->connected = false;
+ /*
+ * Don't hang the OS trying to handle the ATN bit, other end will
+ * resend on a reconnect.
+ */
+ k->set_atn(s, 0, 0);
if (ibe->waiting_rsp) {
ibe->waiting_rsp = false;
ibe->inbuf[1] = ibe->outbuf[1] | 0x04;
--
2.7.4
next prev parent reply other threads:[~2018-02-01 18:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 18:52 [Qemu-devel] [PULL 0/7] Small IPMI fixes minyard
2018-02-01 18:52 ` [Qemu-devel] [PATCH 1/7] Add maintainer for the IPMI code minyard
2018-02-01 18:52 ` [Qemu-devel] [PATCH 2/7] ipmi: Fix SEL get/set time commands minyard
2018-02-01 18:52 ` [Qemu-devel] [PATCH 3/7] ipmi: Don't set the timestamp on add events that don't have it minyard
2018-02-01 18:52 ` [Qemu-devel] [PATCH 4/7] ipmi: Add the platform event message command minyard
2018-02-01 18:53 ` [Qemu-devel] [PATCH 5/7] ipmi: Fix macro issues minyard
2018-02-01 18:53 ` minyard [this message]
2018-02-01 18:53 ` [Qemu-devel] [PATCH 7/7] ipmi: Allow BMC device properties to be set minyard
2018-02-02 14:52 ` [Qemu-devel] [PULL 0/7] Small IPMI fixes Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2018-01-16 0:57 [Qemu-devel] [PATCH v2] " minyard
2018-01-16 0:57 ` [Qemu-devel] [PATCH 6/7] ipmi: disable IRQ and ATN on an external disconnect minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517511182-9944-7-git-send-email-minyard@acm.org \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).