* [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB
@ 2018-02-13 16:41 Geert Uytterhoeven
2018-02-13 19:45 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-02-13 16:41 UTC (permalink / raw)
To: Peter Crosthwaite, Alexander Graf
Cc: qemu-devel, linux-renesas-soc, Geert Uytterhoeven
It is not uncommon for a contemporary FDT to be larger than 64 KiB,
leading to failures loading the device tree from sysfs:
qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE
For reference, the largest arm64 DTB created from the Linux sources is
70 KiB large (93 KiB when built with symbols/fixup support).
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
device_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/device_tree.c b/device_tree.c
index a24ddff02bdd857c..1ba9b8e0a49e6bbc 100644
--- a/device_tree.c
+++ b/device_tree.c
@@ -29,7 +29,7 @@
#include <libfdt.h>
-#define FDT_MAX_SIZE 0x10000
+#define FDT_MAX_SIZE 0x20000
void *create_device_tree(int *sizep)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB
2018-02-13 16:41 [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB Geert Uytterhoeven
@ 2018-02-13 19:45 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2018-02-13 19:45 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Peter Crosthwaite, Alexander Graf, Linux-Renesas, QEMU Developers
On 13 February 2018 at 16:41, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> It is not uncommon for a contemporary FDT to be larger than 64 KiB,
> leading to failures loading the device tree from sysfs:
>
> qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE
>
> For reference, the largest arm64 DTB created from the Linux sources is
> 70 KiB large (93 KiB when built with symbols/fixup support).
I think we should probably give ourselves a bit more headroom,
then -- at least 256K.
The ppc boards actually define their own version of this constant:
#define FDT_MAX_SIZE 0x00100000
so I think we might as well just go with that in device_tree.c for
consistency.
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-13 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-13 16:41 [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB Geert Uytterhoeven
2018-02-13 19:45 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).