qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Collin L. Walling" <walling@linux.vnet.ibm.com>
To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, frankja@linux.vnet.ibm.com,
	cohuck@redhat.com, thuth@redhat.com, david@redhat.com,
	alifm@linux.vnet.ibm.com, eblake@redhat.com,
	mihajlov@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v6 12/12] s390-ccw: interactive boot menu for scsi
Date: Thu, 15 Feb 2018 17:54:33 -0500	[thread overview]
Message-ID: <1518735273-16089-13-git-send-email-walling@linux.vnet.ibm.com> (raw)
In-Reply-To: <1518735273-16089-1-git-send-email-walling@linux.vnet.ibm.com>

Interactive boot menu for scsi. This follows a similar procedure
as the interactive menu for eckd dasd. An example follows:

    s390x Enumerated Boot Menu.

    3 entries detected. Select from index 0 to 2.

Signed-off-by: Collin L. Walling <walling@linux.vnet.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
 pc-bios/s390-ccw/bootmap.c |  4 ++++
 pc-bios/s390-ccw/main.c    |  1 +
 pc-bios/s390-ccw/menu.c    | 14 ++++++++++++++
 pc-bios/s390-ccw/menu.h    |  1 +
 4 files changed, 20 insertions(+)

diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
index 5358301..a75550f 100644
--- a/pc-bios/s390-ccw/bootmap.c
+++ b/pc-bios/s390-ccw/bootmap.c
@@ -568,6 +568,10 @@ static void ipl_scsi(void)
     debug_print_int("program table entries", program_table_entries);
     IPL_assert(program_table_entries != 0, "Empty Program Table");
 
+    if (menu_check_flags(BOOT_MENU_FLAG_CMD_OPTS)) {
+        loadparm = menu_get_enum_boot_index(program_table_entries);
+    }
+
     debug_print_int("loadparm", loadparm);
     IPL_assert(loadparm <= MAX_TABLE_ENTRIES, "loadparm value greater than"
                " maximum number of boot entries allowed");
diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
index c643a6b..2226871 100644
--- a/pc-bios/s390-ccw/main.c
+++ b/pc-bios/s390-ccw/main.c
@@ -92,6 +92,7 @@ static void menu_setup(void)
 
     switch (iplb.pbt) {
     case S390_IPL_TYPE_CCW:
+    case S390_IPL_TYPE_QEMU_SCSI:
         menu_set_parms(qipl.boot_menu_flags, qipl.boot_menu_timeout);
         return;
     }
diff --git a/pc-bios/s390-ccw/menu.c b/pc-bios/s390-ccw/menu.c
index 14410a8..d104327 100644
--- a/pc-bios/s390-ccw/menu.c
+++ b/pc-bios/s390-ccw/menu.c
@@ -215,6 +215,20 @@ int menu_get_zipl_boot_index(const void *stage2, int offset)
     return get_boot_index(ct - 1);
 }
 
+int menu_get_enum_boot_index(int entries)
+{
+    char tmp[4];
+
+    sclp_print("s390x Enumerated Boot Menu.\n\n");
+
+    sclp_print(uitoa(entries, tmp, sizeof(tmp)));
+    sclp_print(" entries detected. Select from boot index 0 to ");
+    sclp_print(uitoa(entries - 1, tmp, sizeof(tmp)));
+    sclp_print(".\n\n");
+
+    return get_boot_index(entries);
+}
+
 void menu_set_parms(uint8_t boot_menu_flag, uint32_t boot_menu_timeout)
 {
     flags = boot_menu_flag;
diff --git a/pc-bios/s390-ccw/menu.h b/pc-bios/s390-ccw/menu.h
index c603de3..790516c 100644
--- a/pc-bios/s390-ccw/menu.h
+++ b/pc-bios/s390-ccw/menu.h
@@ -18,6 +18,7 @@
 #define BOOT_MENU_FLAG_ZIPL_OPTS 0x40
 
 int menu_get_zipl_boot_index(const void *stage2, int offset);
+int menu_get_enum_boot_index(int entries);
 void menu_set_parms(uint8_t boot_menu_flags, uint32_t boot_menu_timeout);
 bool menu_check_flags(uint8_t check_flags);
 
-- 
2.7.4

      parent reply	other threads:[~2018-02-15 23:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 22:54 [Qemu-devel] [PATCH v6 00/12] Interactive Boot Menu for DASD and SCSI Guests on s390x Collin L. Walling
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 01/12] s390-ccw: refactor boot map table code Collin L. Walling
2018-02-16 10:42   ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-02-16 12:19     ` Viktor Mihajlovski
2018-02-16 14:57       ` Collin L. Walling
2018-02-16 15:54         ` Thomas Huth
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 02/12] s390-ccw: refactor eckd_block_num to use CHS Collin L. Walling
2018-02-16 10:44   ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 03/12] s390-ccw: refactor IPL structs Collin L. Walling
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 04/12] s390-ccw: update libc Collin L. Walling
2018-02-16 16:05   ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-02-16 16:08     ` Collin L. Walling
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 05/12] s390-ccw: move auxiliary IPL data to separate location Collin L. Walling
2018-02-16 12:25   ` Viktor Mihajlovski
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 06/12] s390-ccw: parse and set boot menu options Collin L. Walling
2018-02-16 16:20   ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-02-16 16:25     ` Collin L. Walling
2018-02-16 16:36     ` Viktor Mihajlovski
2018-02-16 16:44       ` Collin L. Walling
2018-02-16 16:54         ` Viktor Mihajlovski
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 07/12] s390-ccw: set up interactive boot menu parameters Collin L. Walling
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 08/12] s390-ccw: read stage2 boot loader data to find menu Collin L. Walling
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 09/12] s390-ccw: print zipl boot menu Collin L. Walling
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 10/12] s390-ccw: read user input for boot index via the SCLP console Collin L. Walling
2018-02-16 15:03   ` David Hildenbrand
2018-02-16 15:13     ` Collin L. Walling
2018-02-15 22:54 ` [Qemu-devel] [PATCH v6 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs Collin L. Walling
2018-02-15 22:54 ` Collin L. Walling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518735273-16089-13-git-send-email-walling@linux.vnet.ibm.com \
    --to=walling@linux.vnet.ibm.com \
    --cc=alifm@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=eblake@redhat.com \
    --cc=frankja@linux.vnet.ibm.com \
    --cc=mihajlov@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).