From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoBu0-0002LX-Fm for qemu-devel@nongnu.org; Tue, 20 Feb 2018 12:40:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoBtz-0000T1-Jx for qemu-devel@nongnu.org; Tue, 20 Feb 2018 12:40:28 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:39580 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eoBtz-0000SS-BI for qemu-devel@nongnu.org; Tue, 20 Feb 2018 12:40:27 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB8694023EDE for ; Tue, 20 Feb 2018 17:40:16 +0000 (UTC) From: Thomas Huth Date: Tue, 20 Feb 2018 18:39:58 +0100 Message-Id: <1519148406-15006-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/8] Improvements and clean-ups related to -net List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Jason Wang , "Dr. David Alan Gilbert" Cc: Paolo Bonzini , Eric Blake , Stefan Hajnoczi "-net" is a legacy option that often causes confusion and misconfigurations for the users, since most people are not aware of the underlying "vlan" (i.e. hub) concept that is used for this parameter. The prefered way of configuring your network stack is to use "--netdev" instead, which gives you a clean 1:1 connection between your emulated guest hardware and the host network backend. However, there are two reasons why we could not completely deprecate "-net" yet: 1) Convenience: In some cases, it's more convenient to use "-net" instead of "--netdev", e.g. if you just want to have a "tap" network connection, it's faster to type "-net nic -net tap" instead of "--device e1000,netdev=n1 --netdev tap,id=n1". 2) On-board NICs: Currently the "-net nic" parameter is the only way to configure on-board NICs on certain (embedded) machines via the nd_table[] array. So beside some generic clean-ups and removal of code that has been marked as deprecated since QEMU 2.10 already, this patch series intro- duces a new parameter "--nic" (in patch 7/8) which should be able to replace "-net" in the long run completely: This new convenience parameter can be used to configure the default/on-board guest HW together with a host network backend in a very compact way. To configure a tap backend for the default NIC, you just have to type "--nic tap" here for example. The last patch finally makes "-net" less prominent in our qemu docs, e.g. by replacing the examples that contain "-net" with "--netdev". Note that "-net" itself is not marked as deprecated yet - I think we should rather do that after one or two QEMU release with "--nic" so that we have enough time to test / get used to the new parameter first. Or we should likely even keep the "-net" around for a couple of years since there are a lot of scripts and tools out there that still use this legacy parameter... v2: - Renamed "-n" to "--nic" (suggested by Paolo) - Improved the QAPI comment about the removal of 'dump (suggested by Eric) - exit(0) instead of exit(1) after showing the "-netdev help" (Eric) - Improved the documenation for hubport a little bit (suggested by Paolo) Thomas Huth (8): net: Move error reporting from net_init_client/netdev to the calling site net: List available netdevs with "-netdev help" net: Only show vhost-user in the help text if CONFIG_POSIX is defined net: Make net_client_init() static net: Remove the deprecated way of dumping network packets net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands net: Add a new convenience option "--nic" to configure default/on-board NICs qemu-doc: Make "-net" less prominent hmp-commands.hx | 30 ------ hmp.h | 3 - include/net/net.h | 4 +- include/sysemu/sysemu.h | 1 + monitor.c | 61 ------------ net/dump.c | 102 +-------------------- net/net.c | 239 +++++++++++++++++++++++------------------------- qapi/net.json | 29 ++---- qemu-doc.texi | 16 ---- qemu-options.hx | 224 ++++++++++++++++++++++++--------------------- tests/test-hmp.c | 2 - vl.c | 10 +- 12 files changed, 256 insertions(+), 465 deletions(-) -- 1.8.3.1