qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Eric Blake <eblake@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v2 3/8] net: Only show vhost-user in the help text if CONFIG_POSIX is defined
Date: Tue, 20 Feb 2018 18:40:01 +0100	[thread overview]
Message-ID: <1519148406-15006-4-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1519148406-15006-1-git-send-email-thuth@redhat.com>

According to net/Makefile.objs we only link in the vhost-user code
if CONFIG_POSIX has been set. So the help screen should also only
show this information if CONFIG_POSIX has been defined.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qemu-options.hx | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qemu-options.hx b/qemu-options.hx
index 8ccd5dc..9ae49a0 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1998,8 +1998,10 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
     "                VALE port (created on the fly) called 'name' ('nmname' is name of the \n"
     "                netmap device, defaults to '/dev/netmap')\n"
 #endif
+#ifdef CONFIG_POSIX
     "-netdev vhost-user,id=str,chardev=dev[,vhostforce=on|off]\n"
     "                configure a vhost-user network, backed by a chardev 'dev'\n"
+#endif
     "-netdev hubport,id=str,hubid=n[,netdev=nd]\n"
     "                configure a hub port on QEMU VLAN 'n'\n", QEMU_ARCH_ALL)
 DEF("net", HAS_ARG, QEMU_OPTION_net,
-- 
1.8.3.1

  parent reply	other threads:[~2018-02-20 17:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 17:39 [Qemu-devel] [PATCH v2 0/8] Improvements and clean-ups related to -net Thomas Huth
2018-02-20 17:39 ` [Qemu-devel] [PATCH v2 1/8] net: Move error reporting from net_init_client/netdev to the calling site Thomas Huth
2018-02-20 17:40 ` [Qemu-devel] [PATCH v2 2/8] net: List available netdevs with "-netdev help" Thomas Huth
2018-02-20 22:28   ` Eric Blake
2018-02-20 17:40 ` Thomas Huth [this message]
2018-02-20 17:40 ` [Qemu-devel] [PATCH v2 4/8] net: Make net_client_init() static Thomas Huth
2018-02-20 17:40 ` [Qemu-devel] [PATCH v2 5/8] net: Remove the deprecated way of dumping network packets Thomas Huth
2018-02-20 22:35   ` Eric Blake
2018-02-21  0:20     ` Thomas Huth
2018-02-20 17:40 ` [Qemu-devel] [PATCH v2 6/8] net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands Thomas Huth
2018-02-20 17:40 ` [Qemu-devel] [PATCH v2 7/8] net: Add a new convenience option "--nic" to configure default/on-board NICs Thomas Huth
2018-02-20 18:37   ` Paolo Bonzini
2018-02-20 17:40 ` [Qemu-devel] [PATCH v2 8/8] qemu-doc: Make "-net" less prominent Thomas Huth
2018-02-20 18:37   ` Paolo Bonzini
2018-02-21  0:05     ` Thomas Huth
2018-02-21  9:12       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519148406-15006-4-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).