qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	"Collin L. Walling" <walling@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Subject: [Qemu-devel] [PULL-for-s390x 13/14] s390-ccw: interactive boot menu for scsi
Date: Mon, 26 Feb 2018 11:42:36 +0100	[thread overview]
Message-ID: <1519641757-12396-14-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1519641757-12396-1-git-send-email-thuth@redhat.com>

From: "Collin L. Walling" <walling@linux.vnet.ibm.com>

Interactive boot menu for scsi. This follows a similar procedure
as the interactive menu for eckd dasd. An example follows:

    s390x Enumerated Boot Menu.

    3 entries detected. Select from index 0 to 2.

Signed-off-by: Collin L. Walling <walling@linux.vnet.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
[thuth: Added additional "break;" statement to avoid analyzer warnings]
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/s390x/ipl.c              |  2 ++
 pc-bios/s390-ccw/bootmap.c  |  4 ++++
 pc-bios/s390-ccw/main.c     |  1 +
 pc-bios/s390-ccw/menu.c     | 20 ++++++++++++++++++++
 pc-bios/s390-ccw/s390-ccw.h |  2 ++
 5 files changed, 29 insertions(+)

diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index c12e460..798e99a 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -247,6 +247,8 @@ static void s390_ipl_set_boot_menu(S390IPLState *ipl)
             return;
         }
         break;
+    case S390_IPL_TYPE_QEMU_SCSI:
+        break;
     default:
         error_report("boot menu is not supported for this device type.");
         return;
diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
index ae93b55..29bfd8c 100644
--- a/pc-bios/s390-ccw/bootmap.c
+++ b/pc-bios/s390-ccw/bootmap.c
@@ -568,6 +568,10 @@ static void ipl_scsi(void)
     debug_print_int("program table entries", program_table_entries);
     IPL_assert(program_table_entries != 0, "Empty Program Table");
 
+    if (menu_is_enabled_enum()) {
+        loadparm = menu_get_enum_boot_index(program_table_entries);
+    }
+
     debug_print_int("loadparm", loadparm);
     IPL_assert(loadparm <= MAX_TABLE_ENTRIES, "loadparm value greater than"
                " maximum number of boot entries allowed");
diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
index a7473b0..9d9f8cf 100644
--- a/pc-bios/s390-ccw/main.c
+++ b/pc-bios/s390-ccw/main.c
@@ -92,6 +92,7 @@ static void menu_setup(void)
 
     switch (iplb.pbt) {
     case S390_IPL_TYPE_CCW:
+    case S390_IPL_TYPE_QEMU_SCSI:
         menu_set_parms(qipl.qipl_flags & BOOT_MENU_FLAG_MASK,
                        qipl.boot_menu_timeout);
         return;
diff --git a/pc-bios/s390-ccw/menu.c b/pc-bios/s390-ccw/menu.c
index ee56939..96eec81 100644
--- a/pc-bios/s390-ccw/menu.c
+++ b/pc-bios/s390-ccw/menu.c
@@ -217,6 +217,21 @@ int menu_get_zipl_boot_index(const char *menu_data)
     return get_boot_index(entries - 1); /* subtract 1 to exclude banner */
 }
 
+
+int menu_get_enum_boot_index(int entries)
+{
+    char tmp[4];
+
+    sclp_print("s390x Enumerated Boot Menu.\n\n");
+
+    sclp_print(uitoa(entries, tmp, sizeof(tmp)));
+    sclp_print(" entries detected. Select from boot index 0 to ");
+    sclp_print(uitoa(entries - 1, tmp, sizeof(tmp)));
+    sclp_print(".\n\n");
+
+    return get_boot_index(entries);
+}
+
 void menu_set_parms(uint8_t boot_menu_flag, uint32_t boot_menu_timeout)
 {
     flag = boot_menu_flag;
@@ -227,3 +242,8 @@ bool menu_is_enabled_zipl(void)
 {
     return flag & (QIPL_FLAG_BM_OPTS_CMD | QIPL_FLAG_BM_OPTS_ZIPL);
 }
+
+bool menu_is_enabled_enum(void)
+{
+    return flag & QIPL_FLAG_BM_OPTS_CMD;
+}
diff --git a/pc-bios/s390-ccw/s390-ccw.h b/pc-bios/s390-ccw/s390-ccw.h
index c4ddf9f..fd18da2 100644
--- a/pc-bios/s390-ccw/s390-ccw.h
+++ b/pc-bios/s390-ccw/s390-ccw.h
@@ -91,6 +91,8 @@ void zipl_load(void);
 void menu_set_parms(uint8_t boot_menu_flag, uint32_t boot_menu_timeout);
 int menu_get_zipl_boot_index(const char *menu_data);
 bool menu_is_enabled_zipl(void);
+int menu_get_enum_boot_index(int entries);
+bool menu_is_enabled_enum(void);
 
 static inline void fill_hex(char *out, unsigned char val)
 {
-- 
1.8.3.1

  parent reply	other threads:[~2018-02-26 10:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 10:42 [Qemu-devel] [PULL-for-s390x 00/14] s390-ccw firmware update Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 01/14] s390-ccw: refactor boot map table code Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 02/14] s390-ccw: refactor eckd_block_num to use CHS Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 03/14] s390-ccw: refactor IPL structs Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 04/14] s390-ccw: update libc Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 05/14] s390-ccw: move auxiliary IPL data to separate location Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 06/14] s390-ccw: parse and set boot menu options Thomas Huth
2018-02-26 18:48   ` Cornelia Huck
2018-02-26 19:29     ` [Qemu-devel] [qemu-s390x] " Collin L. Walling
2018-02-26 19:44       ` Collin L. Walling
2018-02-27  9:12         ` Cornelia Huck
2018-02-27  9:22           ` Thomas Huth
2018-02-27 15:04             ` Collin L. Walling
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 07/14] s390-ccw: set up interactive boot menu parameters Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 08/14] s390-ccw: read stage2 boot loader data to find menu Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 09/14] s390-ccw: print zipl boot menu Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 10/14] s390-ccw: read user input for boot index via the SCLP console Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 11/14] s390-ccw: set cp_receive mask only when needed and consume pending service irqs Thomas Huth
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 12/14] s390-ccw: use zipl values when no boot menu options are present Thomas Huth
2018-02-26 10:42 ` Thomas Huth [this message]
2018-02-26 10:42 ` [Qemu-devel] [PULL-for-s390x 14/14] pc-bios/s390: Rebuild the s390x firmware images with the boot menu changes Thomas Huth
2018-02-27  9:30 ` [Qemu-devel] [PULL-for-s390x 00/14] s390-ccw firmware update Cornelia Huck
2018-02-27 17:56 ` Peter Maydell
2018-02-27 18:51   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519641757-12396-14-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=walling@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).