qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Shannon Zhao <zhaoshenglong@huawei.com>,
	Auger Eric <eric.auger@redhat.com>,
	qemu-arm@nongnu.org
Subject: [Qemu-devel] [PATCH v2 05/10] acpi: move ACPI_PORT_SMI_CMD define to header it belongs to
Date: Wed, 28 Feb 2018 15:23:50 +0100	[thread overview]
Message-ID: <1519827835-239519-6-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1519827835-239519-1-git-send-email-imammedo@redhat.com>

ACPI_PORT_SMI_CMD is alias for APM_CNT_IOPORT,
so make it really one instead of duplicating its value.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 include/hw/isa/apm.h | 3 +++
 hw/i386/acpi-build.c | 2 --
 hw/isa/apm.c         | 1 -
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/hw/isa/apm.h b/include/hw/isa/apm.h
index 4839ff1..b7098bf 100644
--- a/include/hw/isa/apm.h
+++ b/include/hw/isa/apm.h
@@ -5,6 +5,9 @@
 #include "hw/hw.h"
 #include "exec/memory.h"
 
+#define APM_CNT_IOPORT  0xb2
+#define ACPI_PORT_SMI_CMD APM_CNT_IOPORT
+
 typedef void (*apm_ctrl_changed_t)(uint32_t val, void *arg);
 
 typedef struct APMState {
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index b85fefe..699f3a0 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -255,8 +255,6 @@ static void acpi_get_pci_holes(Range *hole, Range *hole64)
                                                NULL));
 }
 
-#define ACPI_PORT_SMI_CMD           0x00b2 /* TODO: this is APM_CNT_IOPORT */
-
 static void acpi_align_size(GArray *blob, unsigned align)
 {
     /* Align size to multiple of given size. This reduces the chance
diff --git a/hw/isa/apm.c b/hw/isa/apm.c
index e232b0d..c3101ef 100644
--- a/hw/isa/apm.c
+++ b/hw/isa/apm.c
@@ -34,7 +34,6 @@
 #endif
 
 /* fixed I/O location */
-#define APM_CNT_IOPORT  0xb2
 #define APM_STS_IOPORT  0xb3
 
 static void apm_ioport_writeb(void *opaque, hwaddr addr, uint64_t val,
-- 
2.7.4

  parent reply	other threads:[~2018-02-28 14:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 14:23 [Qemu-devel] [PATCH v2 00/10] generalize build_fadt() Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 01/10] acpi: remove unused acpi-dsdt.aml Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 02/10] pc: replace pm object initialization with one-liner in acpi_get_pm_info() Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 03/10] acpi: reuse AcpiGenericAddress instead of Acpi20GenericAddress Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 04/10] acpi: add build_append_gas() helper for Generic Address Structure Igor Mammedov
2018-02-28 14:23 ` Igor Mammedov [this message]
2018-03-01  8:41   ` [Qemu-devel] [PATCH v2 05/10] acpi: move ACPI_PORT_SMI_CMD define to header it belongs to Auger Eric
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 06/10] pc: acpi: isolate FADT specific data into AcpiFadtData structure Igor Mammedov
2018-03-01  8:43   ` Auger Eric
2018-03-01  9:39     ` Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 07/10] pc: acpi: use build_append_foo() API to construct FADT Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 08/10] acpi: move build_fadt() from i386 specific to generic ACPI source Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 09/10] virt_arm: acpi: reuse common build_fadt() Igor Mammedov
2018-03-01  8:51   ` Auger Eric
2018-03-01  9:21     ` Igor Mammedov
2018-03-01  9:38       ` Auger Eric
2018-03-01 16:43         ` Igor Mammedov
2018-02-28 14:23 ` [Qemu-devel] [PATCH v2 10/10] tests: acpi: don't read all fields in test_acpi_fadt_table() Igor Mammedov
2018-03-01  8:59   ` Auger Eric
2018-03-01  8:52 ` [Qemu-devel] [PATCH v2 00/10] generalize build_fadt() Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519827835-239519-6-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).