From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
linzhecheng <linzhecheng@huawei.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Jason Wang" <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 01/13] vhost-user: fix memory leak
Date: Thu, 1 Mar 2018 18:45:53 +0200 [thread overview]
Message-ID: <1519922735-29054-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1519922735-29054-1-git-send-email-mst@redhat.com>
From: linzhecheng <linzhecheng@huawei.com>
g_free() was moved from vhost_net_cleanup in commit e6bcb1b, so we should
free net after vhost_net_cleanup
Signed-off-by: linzhecheng <linzhecheng@huawei.com>
Reviewed-by: Marc-André Lureau < marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
net/vhost-user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/vhost-user.c b/net/vhost-user.c
index cb45512..d024573 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -109,6 +109,7 @@ static int vhost_user_start(int queues, NetClientState *ncs[], CharBackend *be)
err:
if (net) {
vhost_net_cleanup(net);
+ g_free(net);
}
vhost_user_stop(i, ncs);
return -1;
--
MST
next prev parent reply other threads:[~2018-03-01 16:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 16:45 [Qemu-devel] [PULL 00/13] virtio, vhost, pci, pc: features, fixes and cleanups Michael S. Tsirkin
2018-03-01 16:45 ` Michael S. Tsirkin [this message]
2018-03-01 16:45 ` [Qemu-devel] [PULL 02/13] virtio-pci: trivial fixes in error message Michael S. Tsirkin
2018-03-01 16:45 ` [Qemu-devel] [PULL 03/13] intel-iommu: Accept 64-bit writes to FEADDR Michael S. Tsirkin
2018-03-01 16:45 ` [Qemu-devel] [PULL 04/13] docs: document virtio-balloon stats Michael S. Tsirkin
2018-03-01 16:45 ` [Qemu-devel] [PULL 05/13] docs: pcie: Spell out machine type needs for PCIe features Michael S. Tsirkin
2018-03-01 16:46 ` [Qemu-devel] [PULL 06/13] vhost: fix memslot limit check Michael S. Tsirkin
2018-03-01 16:46 ` [Qemu-devel] [PULL 07/13] vhost: avoid to start/stop virtqueue which is not ready Michael S. Tsirkin
2018-03-01 16:46 ` [Qemu-devel] [PULL 09/13] docs/vmcoreinfo: detail unsupported host format behaviour Michael S. Tsirkin
2018-03-01 16:46 ` [Qemu-devel] [PULL 08/13] vhost: fix incorrect check in vhost_verify_ring_mappings Michael S. Tsirkin
2018-03-01 16:46 ` [Qemu-devel] [PULL 11/13] cryptodev: add vhost support Michael S. Tsirkin
2018-03-01 16:46 ` [Qemu-devel] [PULL 10/13] cryptodev: add vhost-user as a new cryptodev backend Michael S. Tsirkin
2018-04-27 16:15 ` Peter Maydell
2018-04-28 0:59 ` Zhoujian (jay)
2018-03-01 16:46 ` [Qemu-devel] [PULL 12/13] cryptodev-vhost-user: add crypto session handler Michael S. Tsirkin
2018-03-01 16:46 ` [Qemu-devel] [PULL 13/13] cryptodev-vhost-user: set the key length Michael S. Tsirkin
2018-03-01 17:17 ` [Qemu-devel] [PULL 00/13] virtio, vhost, pci, pc: features, fixes and cleanups no-reply
2018-03-01 17:21 ` no-reply
2018-03-02 11:17 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519922735-29054-2-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=linzhecheng@huawei.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).