From: Julia Suvorova <jusual@mail.ru>
To: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Jim Mussared" <jim@groklearning.com>,
"Joel Stanley" <joel@jms.id.au>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Julia Suvorova" <jusual@mail.ru>
Subject: [Qemu-devel] [PATCH] checkpatch: add a warning for basename/dirname
Date: Fri, 2 Mar 2018 11:22:45 +0300 [thread overview]
Message-ID: <1519978965-16865-1-git-send-email-jusual@mail.ru> (raw)
Signed-off-by: Julia Suvorova <jusual@mail.ru>
---
scripts/checkpatch.pl | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 1b4b812..6c4fb42 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2584,6 +2584,11 @@ sub process {
ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
}
+# recommend g_path_get_* over basename(3) and dirname(3)
+ if ($line =~ /\b(basename|dirname)\s*\(/) {
+ WARN("consider using g_path_get_$1 in preference to $1(3)\n" . $herecurr);
+ }
+
# recommend qemu_strto* over strto* for numeric conversions
if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr);
--
2.1.4
next reply other threads:[~2018-03-02 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 8:22 Julia Suvorova [this message]
2018-03-02 8:25 ` [Qemu-devel] [PATCH] checkpatch: add a warning for basename/dirname no-reply
2018-03-02 8:56 ` Paolo Bonzini
2018-03-02 9:27 ` Julia Suvorova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519978965-16865-1-git-send-email-jusual@mail.ru \
--to=jusual@mail.ru \
--cc=cohuck@redhat.com \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).