From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erfyu-0008Bn-Hw for qemu-devel@nongnu.org; Fri, 02 Mar 2018 03:23:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erfyq-0003rr-Jl for qemu-devel@nongnu.org; Fri, 02 Mar 2018 03:23:56 -0500 Received: from smtp55.i.mail.ru ([217.69.128.35]:54002) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erfyq-0003oq-3n for qemu-devel@nongnu.org; Fri, 02 Mar 2018 03:23:52 -0500 From: Julia Suvorova Date: Fri, 2 Mar 2018 11:22:45 +0300 Message-Id: <1519978965-16865-1-git-send-email-jusual@mail.ru> Subject: [Qemu-devel] [PATCH] checkpatch: add a warning for basename/dirname List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefan Hajnoczi Cc: Jim Mussared , Joel Stanley , Paolo Bonzini , Cornelia Huck , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Julia Suvorova Signed-off-by: Julia Suvorova --- scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 1b4b812..6c4fb42 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2584,6 +2584,11 @@ sub process { ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); } +# recommend g_path_get_* over basename(3) and dirname(3) + if ($line =~ /\b(basename|dirname)\s*\(/) { + WARN("consider using g_path_get_$1 in preference to $1(3)\n" . $herecurr); + } + # recommend qemu_strto* over strto* for numeric conversions if ($line =~ /\b(strto[^kd].*?)\s*\(/) { ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr); -- 2.1.4