From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eriAJ-00014c-N5 for qemu-devel@nongnu.org; Fri, 02 Mar 2018 05:43:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eriAG-000813-JJ for qemu-devel@nongnu.org; Fri, 02 Mar 2018 05:43:51 -0500 Received: from smtp2.mail.ru ([94.100.179.91]:48570) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eriAG-00080W-6w for qemu-devel@nongnu.org; Fri, 02 Mar 2018 05:43:48 -0500 From: Julia Suvorova Date: Fri, 2 Mar 2018 13:43:19 +0300 Message-Id: <1519987399-19160-1-git-send-email-jusual@mail.ru> Subject: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefan Hajnoczi Cc: Jim Mussared , Joel Stanley , Paolo Bonzini , Cornelia Huck , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Julia Suvorova g_path_get_* do the same as g_strdup(basename/dirname(...)) but without modifying the argument. Signed-off-by: Julia Suvorova --- scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 1b4b812..a88af61 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2584,6 +2584,11 @@ sub process { ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); } +# recommend g_path_get_* over g_strdup(basename/dirname(...)) + if ($line =~ /\bg_strdup\s*\(\s*(basename|dirname)\s*\(/) { + WARN("consider using g_path_get_$1() in preference to g_strdup($1())\n" . $herecurr); + } + # recommend qemu_strto* over strto* for numeric conversions if ($line =~ /\b(strto[^kd].*?)\s*\(/) { ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr); -- 2.1.4