From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63CF9C47096 for ; Thu, 3 Jun 2021 07:40:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C43BA610E7 for ; Thu, 3 Jun 2021 07:40:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C43BA610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lohxV-0006hP-L1 for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 03:40:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lohwH-0005si-9r for qemu-devel@nongnu.org; Thu, 03 Jun 2021 03:38:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25244) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lohwB-0004UT-VF for qemu-devel@nongnu.org; Thu, 03 Jun 2021 03:38:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622705921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b3xlrkxbjl76Zdl98exJ1Fl8WJSrJCtgh2baTRVVano=; b=BGXOeRfmKb7wYB7wQlqzRl04bYM8K+/DFxrbLmU0p3GkX9UnIBS7d5SUXRgvubd2o/Z24V 8WEw/KW9iKy49DDpOri3oaA0sz0hCUES2rWB9aP1RKJ5BEgOcG4hz3UKZqLLbcZKCtQV4E Rsx2EJT71oh+KQX/ByNCkXTqUlbZCIA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-H5Fv_UHfPUWhV_94OYTWlA-1; Thu, 03 Jun 2021 03:38:37 -0400 X-MC-Unique: H5Fv_UHfPUWhV_94OYTWlA-1 Received: by mail-ed1-f70.google.com with SMTP id m16-20020a0564024310b029039182495fb1so552593edc.16 for ; Thu, 03 Jun 2021 00:38:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b3xlrkxbjl76Zdl98exJ1Fl8WJSrJCtgh2baTRVVano=; b=f/CjQ4/nfCVvHHGw6uwXk+4SLZnG70sFRK4JwW17F817XqRIfnMJniodhQ3dyLObL8 IcBt70Ks/DpbRG5ZGC7UAUtnku7894VDatkQM2nvYFYso/jQXZzlK0hv1beCFNh4Vuf3 1kyreV5h0XCH1okAbpuO7XS+DALUq9eCr6UpeCEQORVs7O6hP467LrpdX15xKxV94p0k WPGTcmaQbE0aHp3m/NgWfMk7GUBRmVl0bHEwfpsBzLmeHNtMns4rKva/QPP8ulvhIXxm Jmfisn+kiOtqd3cGjTbrRsfscbQlh5UJIJ7lYd+W6cmemc2Abw5dsL6h1sFLxW+P7pmR 1dng== X-Gm-Message-State: AOAM531pI8E8mkABkvrThN1Cy4vJuzY1ZTCLt81Tb/jqA1bkcDVmoADC D9J/t4iHQDXW+mIBdoPNzn1AKBBMP32h2GDPJa2y3RZTCXnoXRGggYITiKBSC+dVzdOvR6nLAlD H8U+F/lGA9SW/Ej4= X-Received: by 2002:a17:906:f9d1:: with SMTP id lj17mr17436574ejb.345.1622705916696; Thu, 03 Jun 2021 00:38:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk6U7FYy67qNMigRW5UV1yRAoLND/QYKO9yQXAujfNJJk4PYjK6XXZW20vvkbK302wRtXPqw== X-Received: by 2002:a17:906:f9d1:: with SMTP id lj17mr17436560ejb.345.1622705916521; Thu, 03 Jun 2021 00:38:36 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id cf26sm1146607ejb.38.2021.06.03.00.38.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 00:38:36 -0700 (PDT) To: Kevin Wolf , Stefan Hajnoczi References: <20210528141628.44287-1-vsementsov@virtuozzo.com> From: Paolo Bonzini Subject: Re: [PATCH 0/2] block-copy: small fix and refactor Message-ID: <151b2470-9c6c-cda9-a77b-64cdb10a7550@redhat.com> Date: Thu, 3 Jun 2021 09:38:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.613, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eesposit@redhat.com, Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 02/06/21 14:21, Kevin Wolf wrote: > Am 02.06.2021 um 11:13 hat Stefan Hajnoczi geschrieben: >> On Fri, May 28, 2021 at 05:16:26PM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> This is my suggestion how to refactor block-copy to avoid extra atomic >>> operations in >>> "[PATCH v2 0/7] block-copy: protect block-copy internal structures" >>> >>> Vladimir Sementsov-Ogievskiy (2): >>> block-copy: fix block_copy_task_entry() progress update >>> block-copy: refactor copy_range handling >>> >>> block/block-copy.c | 79 +++++++++++++++++++++++++++++++--------------- >>> 1 file changed, 53 insertions(+), 26 deletions(-) >> >> I posted suggestions for the doc comment on Patch 2, otherwise: >> >> Reviewed-by: Stefan Hajnoczi > > Thanks, fixed up the comment accordingly and applied to the block > branch. I'm a bit confused. Vladimir said in his review of Emanuele's patches that he was okay with patch 7 and that he would rebase this refactoring on top of it. Vladimir's main complaint for the s->method state machine was the extra lines of code. Here we have just as many new lines of code and new parameters that are passed by reference. Kevin, can you please look at Emanuele's patches and possibly unqueue the second patch here? It seems to me that it should have been tagged as RFC. Paolo [1] https://patchew.org/QEMU/20210518100757.31243-1-eesposit@redhat.com/20210518100757.31243-8-eesposit@redhat.com/