From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 2/9] net: List available netdevs with "-netdev help"
Date: Mon, 5 Mar 2018 11:11:57 +0800 [thread overview]
Message-ID: <1520219524-17160-3-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1520219524-17160-1-git-send-email-jasowang@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Other options like "-chardev" or "-device" feature a nice help text
with the available devices when being called with "help" or "?".
Since it is quite useful, especially if you want to see which network
backends have been compiled into the QEMU binary, let's provide such
a help text for "-netdev", too.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/net.c | 37 ++++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index e213a61..cf07e15 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1086,6 +1086,38 @@ static int net_client_init1(const void *object, bool is_netdev, Error **errp)
return 0;
}
+static void show_netdevs(void)
+{
+ int idx;
+ const char *available_netdevs[] = {
+ "socket",
+ "hubport",
+ "tap",
+#ifdef CONFIG_SLIRP
+ "user",
+#endif
+#ifdef CONFIG_L2TPV3
+ "l2tpv3",
+#endif
+#ifdef CONFIG_VDE
+ "vde",
+#endif
+#ifdef CONFIG_NET_BRIDGE
+ "bridge",
+#endif
+#ifdef CONFIG_NETMAP
+ "netmap",
+#endif
+#ifdef CONFIG_POSIX
+ "vhost-user",
+#endif
+ };
+
+ printf("Available netdev backend types:\n");
+ for (idx = 0; idx < ARRAY_SIZE(available_netdevs); idx++) {
+ puts(available_netdevs[idx]);
+ }
+}
int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp)
{
@@ -1094,7 +1126,10 @@ int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp)
int ret = -1;
Visitor *v = opts_visitor_new(opts);
- {
+ if (is_netdev && is_help_option(qemu_opt_get(opts, "type"))) {
+ show_netdevs();
+ exit(0);
+ } else {
/* Parse convenience option format ip6-net=fec0::0[/64] */
const char *ip6_net = qemu_opt_get(opts, "ipv6-net");
--
2.7.4
next prev parent reply other threads:[~2018-03-05 3:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 3:11 [Qemu-devel] [PULL 0/9] Net patches Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 1/9] net: Move error reporting from net_init_client/netdev to the calling site Jason Wang
2018-03-05 3:11 ` Jason Wang [this message]
2018-03-05 3:11 ` [Qemu-devel] [PULL 3/9] net: Only show vhost-user in the help text if CONFIG_POSIX is defined Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 4/9] net: Make net_client_init() static Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 5/9] net: Remove the deprecated way of dumping network packets Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 6/9] net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 7/9] net: Add a new convenience option "--nic" to configure default/on-board NICs Jason Wang
2018-04-27 12:29 ` Peter Maydell
2018-04-28 1:51 ` Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 8/9] hw/net: Remove unnecessary header includes Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 9/9] tap: setting error appropriately when calling net_init_tap_one() Jason Wang
2018-03-05 15:16 ` [Qemu-devel] [PULL 0/9] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520219524-17160-3-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).