From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 4/9] net: Make net_client_init() static
Date: Mon, 5 Mar 2018 11:11:59 +0800 [thread overview]
Message-ID: <1520219524-17160-5-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1520219524-17160-1-git-send-email-jasowang@redhat.com>
From: Thomas Huth <thuth@redhat.com>
The function is only used within net.c, so there's no need that
this is a global function.
While we're at it, also remove the unused prototype compute_mcast_idx()
(the function has been removed in commit d9caeb09b107e91122d10ba4a08a).
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
include/net/net.h | 2 --
net/net.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/net/net.h b/include/net/net.h
index bdd4d9f..cd1708c 100644
--- a/include/net/net.h
+++ b/include/net/net.h
@@ -204,7 +204,6 @@ extern const char *host_net_devices[];
extern const char *legacy_tftp_prefix;
extern const char *legacy_bootp_filename;
-int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp);
int net_client_parse(QemuOptsList *opts_list, const char *str);
int net_init_clients(Error **errp);
void net_check_clients(void);
@@ -228,7 +227,6 @@ void qdev_set_nic_properties(DeviceState *dev, NICInfo *nd);
#define POLYNOMIAL_LE 0xedb88320
uint32_t net_crc32(const uint8_t *p, int len);
uint32_t net_crc32_le(const uint8_t *p, int len);
-unsigned compute_mcast_idx(const uint8_t *ep);
#define vmstate_offset_macaddr(_state, _field) \
vmstate_offset_array(_state, _field.a, uint8_t, \
diff --git a/net/net.c b/net/net.c
index cf07e15..dd80f1b 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1119,7 +1119,7 @@ static void show_netdevs(void)
}
}
-int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp)
+static int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp)
{
void *object = NULL;
Error *err = NULL;
--
2.7.4
next prev parent reply other threads:[~2018-03-05 3:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 3:11 [Qemu-devel] [PULL 0/9] Net patches Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 1/9] net: Move error reporting from net_init_client/netdev to the calling site Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 2/9] net: List available netdevs with "-netdev help" Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 3/9] net: Only show vhost-user in the help text if CONFIG_POSIX is defined Jason Wang
2018-03-05 3:11 ` Jason Wang [this message]
2018-03-05 3:12 ` [Qemu-devel] [PULL 5/9] net: Remove the deprecated way of dumping network packets Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 6/9] net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 7/9] net: Add a new convenience option "--nic" to configure default/on-board NICs Jason Wang
2018-04-27 12:29 ` Peter Maydell
2018-04-28 1:51 ` Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 8/9] hw/net: Remove unnecessary header includes Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 9/9] tap: setting error appropriately when calling net_init_tap_one() Jason Wang
2018-03-05 15:16 ` [Qemu-devel] [PULL 0/9] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520219524-17160-5-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).