From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 8/9] hw/net: Remove unnecessary header includes
Date: Mon, 5 Mar 2018 11:12:03 +0800 [thread overview]
Message-ID: <1520219524-17160-9-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1520219524-17160-1-git-send-email-jasowang@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Headers like "hw/loader.h" and "qemu/sockets.h" are not needed in
the hw/net/*.c files. And Some other headers are included via other
headers already, so we can drop them, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/e1000.c | 1 -
hw/net/lance.c | 3 ---
hw/net/ne2000.c | 2 --
hw/net/pcnet-pci.c | 1 -
hw/net/pcnet.c | 1 -
hw/net/rtl8139.c | 2 --
hw/net/xgmac.c | 1 -
7 files changed, 11 deletions(-)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 804ec08..c7f1695 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -30,7 +30,6 @@
#include "hw/pci/pci.h"
#include "net/net.h"
#include "net/checksum.h"
-#include "hw/loader.h"
#include "sysemu/sysemu.h"
#include "sysemu/dma.h"
#include "qemu/iov.h"
diff --git a/hw/net/lance.c b/hw/net/lance.c
index 0028bc5..a08d5ac 100644
--- a/hw/net/lance.c
+++ b/hw/net/lance.c
@@ -36,10 +36,7 @@
*/
#include "qemu/osdep.h"
-#include "hw/sysbus.h"
-#include "net/net.h"
#include "qemu/timer.h"
-#include "qemu/sockets.h"
#include "hw/sparc/sparc32_dma.h"
#include "hw/net/lance.h"
#include "trace.h"
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
index 687ef84..3a9fc89 100644
--- a/hw/net/ne2000.c
+++ b/hw/net/ne2000.c
@@ -23,10 +23,8 @@
*/
#include "qemu/osdep.h"
#include "hw/pci/pci.h"
-#include "net/net.h"
#include "net/eth.h"
#include "ne2000.h"
-#include "hw/loader.h"
#include "sysemu/sysemu.h"
/* debug NE2000 card */
diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c
index 0ae5ca4..70dc8b3 100644
--- a/hw/net/pcnet-pci.c
+++ b/hw/net/pcnet-pci.c
@@ -30,7 +30,6 @@
#include "qemu/osdep.h"
#include "hw/pci/pci.h"
#include "net/net.h"
-#include "hw/loader.h"
#include "qemu/timer.h"
#include "sysemu/dma.h"
#include "sysemu/sysemu.h"
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
index 606b05c..0c44554 100644
--- a/hw/net/pcnet.c
+++ b/hw/net/pcnet.c
@@ -40,7 +40,6 @@
#include "net/net.h"
#include "net/eth.h"
#include "qemu/timer.h"
-#include "qemu/sockets.h"
#include "sysemu/sysemu.h"
#include "trace.h"
diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
index 1cc95b8..46daa16 100644
--- a/hw/net/rtl8139.c
+++ b/hw/net/rtl8139.c
@@ -58,9 +58,7 @@
#include "qemu/timer.h"
#include "net/net.h"
#include "net/eth.h"
-#include "hw/loader.h"
#include "sysemu/sysemu.h"
-#include "qemu/iov.h"
/* debug RTL8139 card */
//#define DEBUG_RTL8139 1
diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c
index 0843bf1..fa00156 100644
--- a/hw/net/xgmac.c
+++ b/hw/net/xgmac.c
@@ -28,7 +28,6 @@
#include "hw/sysbus.h"
#include "qemu/log.h"
#include "net/net.h"
-#include "net/checksum.h"
#ifdef DEBUG_XGMAC
#define DEBUGF_BRK(message, args...) do { \
--
2.7.4
next prev parent reply other threads:[~2018-03-05 3:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 3:11 [Qemu-devel] [PULL 0/9] Net patches Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 1/9] net: Move error reporting from net_init_client/netdev to the calling site Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 2/9] net: List available netdevs with "-netdev help" Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 3/9] net: Only show vhost-user in the help text if CONFIG_POSIX is defined Jason Wang
2018-03-05 3:11 ` [Qemu-devel] [PULL 4/9] net: Make net_client_init() static Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 5/9] net: Remove the deprecated way of dumping network packets Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 6/9] net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands Jason Wang
2018-03-05 3:12 ` [Qemu-devel] [PULL 7/9] net: Add a new convenience option "--nic" to configure default/on-board NICs Jason Wang
2018-04-27 12:29 ` Peter Maydell
2018-04-28 1:51 ` Jason Wang
2018-03-05 3:12 ` Jason Wang [this message]
2018-03-05 3:12 ` [Qemu-devel] [PULL 9/9] tap: setting error appropriately when calling net_init_tap_one() Jason Wang
2018-03-05 15:16 ` [Qemu-devel] [PULL 0/9] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520219524-17160-9-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).