From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 15/34] openpic_kvm: drop address_space_to_flatview call
Date: Tue, 6 Mar 2018 14:19:11 +0100 [thread overview]
Message-ID: <1520342370-123606-16-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com>
The MemoryListener is registered on address_space_memory, there is
not much to assert. This currently works because the callback
is invoked only once when the listener is registered, but section->fv
is the _new_ FlatView, not the old one on later calls and that
would break.
This confines address_space_to_flatview to exec.c and memory.c.
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/intc/openpic_kvm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c
index f1a59e5..928bc04 100644
--- a/hw/intc/openpic_kvm.c
+++ b/hw/intc/openpic_kvm.c
@@ -125,10 +125,6 @@ static void kvm_openpic_region_add(MemoryListener *listener,
uint64_t reg_base;
int ret;
- if (section->fv != address_space_to_flatview(&address_space_memory)) {
- abort();
- }
-
/* Ignore events on regions that are not us */
if (section->mr != &opp->mem) {
return;
--
1.8.3.1
next prev parent reply other threads:[~2018-03-06 13:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 13:18 [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06 Paolo Bonzini
2018-03-06 13:18 ` [Qemu-devel] [PULL 01/34] g364fb: fix DirtyBitmapSnapshot leak Paolo Bonzini
2018-03-06 13:18 ` [Qemu-devel] [PULL 02/34] Remove the deprecated -tdf option Paolo Bonzini
2018-03-06 13:18 ` [Qemu-devel] [PULL 03/34] scsi: Remove automatic creation of SCSI controllers with -drive if=scsi Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 04/34] cpus: properly inititalize CPU > 1 under single-threaded TCG Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 05/34] cpus: wait for CPU creation at central place Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 06/34] cpus: CPU threads are always created initially for one CPU only Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 07/34] Document --rtc-td-hack, --localtime and --startdate as deprecated Paolo Bonzini
2018-03-06 15:13 ` Thomas Huth
2018-03-06 15:20 ` Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 08/34] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 09/34] qmp: Add qom-list-properties to list QOM object properties Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 10/34] build-sys: fix -fsanitize=address check Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 11/34] lockable: workaround GCC link issue with ASAN Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 12/34] ahci-test: fix opts leak of skip tests Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 13/34] sdhci-test: fix leaks Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 14/34] chardev: fix leak in tcp_chr_telnet_init_io() Paolo Bonzini
2018-03-06 13:19 ` Paolo Bonzini [this message]
2018-03-06 13:19 ` [Qemu-devel] [PULL 16/34] memory: inline some performance-sensitive accessors Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 17/34] address_space_write: address_space_to_flatview needs RCU lock Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 18/34] address_space_read: " Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 19/34] address_space_access_valid: " Paolo Bonzini
2018-03-07 12:49 ` Cornelia Huck
2018-03-07 13:00 ` Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 20/34] address_space_map: " Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 21/34] address_space_rw: " Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 22/34] checkpatch: add a warning for basename/dirname Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 23/34] checkpatch: add check for `while` and `for` Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 24/34] Revert "build-sys: compile with -Og or -O1 when --enable-debug" Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 25/34] Fixing WHPX casing to match SDK Paolo Bonzini
2018-03-26 17:02 ` Eric Blake
2018-03-06 13:19 ` [Qemu-devel] [PULL 26/34] Resolves WHPX breaking changes in SDK 17095 Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 27/34] Remove unnecessary WHPX __debugbreak(); Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 28/34] Fix WHPX additional lock acquisition Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 29/34] Fix WHPX typo in 'mmio' Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 30/34] Fix WHPX issue leaking tpr values Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 31/34] WHXP Removes the use of WHvGetExitContextSize Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 32/34] WHPX improve interrupt notification registration Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 33/34] balloon: Fix documentation of the --balloon parameter and deprecate it Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 34/34] use g_path_get_basename instead of basename Paolo Bonzini
2018-03-06 13:54 ` [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06 no-reply
2018-03-06 14:23 ` Peter Maydell
2018-03-07 11:39 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520342370-123606-16-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).