qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Justin Terry (VM)" <juterry@microsoft.com>
Subject: [Qemu-devel] [PULL 26/34] Resolves WHPX breaking changes in SDK 17095
Date: Tue,  6 Mar 2018 14:19:22 +0100	[thread overview]
Message-ID: <1520342370-123606-27-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com>

From: "Justin Terry (VM) via Qemu-devel" <qemu-devel@nongnu.org>

1. Fixes the changes required to the WHvTryMmioEmulation, WHvTryIoEmulation, and
WHvEmulatorCreateEmulator based on the new VpContext forwarding.
2. Removes the WHvRunVpExitReasonAlerted case.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Message-Id: <1519665216-1078-3-git-send-email-juterry@microsoft.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Justin Terry (VM) via Qemu-devel <qemu-devel@nongnu.org>
---
 target/i386/whpx-all.c | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
index eeee43e..969c2f5 100644
--- a/target/i386/whpx-all.c
+++ b/target/i386/whpx-all.c
@@ -613,6 +613,7 @@ static HRESULT CALLBACK whpx_emu_translate_callback(
 }
 
 static const WHV_EMULATOR_CALLBACKS whpx_emu_callbacks = {
+    .Size = sizeof(WHV_EMULATOR_CALLBACKS),
     .WHvEmulatorIoPortCallback = whpx_emu_ioport_callback,
     .WHvEmulatorMemoryCallback = whpx_emu_memio_callback,
     .WHvEmulatorGetVirtualProcessorRegisters = whpx_emu_getreg_callback,
@@ -626,7 +627,9 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_ACCESS_CONTEXT *ctx)
     struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu);
     WHV_EMULATOR_STATUS emu_status;
 
-    hr = WHvEmulatorTryMmioEmulation(vcpu->emulator, cpu, ctx, &emu_status);
+    hr = WHvEmulatorTryMmioEmulation(vcpu->emulator, cpu,
+                                     &vcpu->exit_ctx.VpContext, ctx,
+                                     &emu_status);
     if (FAILED(hr)) {
         __debugbreak();
         error_report("WHPX: Failed to parse MMIO access, hr=%08lx", hr);
@@ -649,7 +652,9 @@ static int whpx_handle_portio(CPUState *cpu,
     struct whpx_vcpu *vcpu = get_whpx_vcpu(cpu);
     WHV_EMULATOR_STATUS emu_status;
 
-    hr = WHvEmulatorTryIoEmulation(vcpu->emulator, cpu, ctx, &emu_status);
+    hr = WHvEmulatorTryIoEmulation(vcpu->emulator, cpu,
+                                   &vcpu->exit_ctx.VpContext, ctx,
+                                   &emu_status);
     if (FAILED(hr)) {
         __debugbreak();
         error_report("WHPX: Failed to parse PortIO access, hr=%08lx", hr);
@@ -905,18 +910,8 @@ static int whpx_vcpu_run(CPUState *cpu)
             whpx_vcpu_kick(cpu);
         }
 
-        for (;;) {
-            hr = WHvRunVirtualProcessor(whpx->partition, cpu->cpu_index,
-                                        &vcpu->exit_ctx, whpx->exit_ctx_size);
-
-            if (SUCCEEDED(hr) && (vcpu->exit_ctx.ExitReason ==
-                                  WHvRunVpExitReasonAlerted)) {
-                WHvCancelRunVirtualProcessor(whpx->partition, cpu->cpu_index,
-                                             0);
-            } else {
-                break;
-            }
-        }
+        hr = WHvRunVirtualProcessor(whpx->partition, cpu->cpu_index,
+                                    &vcpu->exit_ctx, whpx->exit_ctx_size);
 
         if (FAILED(hr)) {
             error_report("WHPX: Failed to exec a virtual processor,"
@@ -956,7 +951,6 @@ static int whpx_vcpu_run(CPUState *cpu)
         case WHvRunVpExitReasonX64MsrAccess:
         case WHvRunVpExitReasonX64Cpuid:
         case WHvRunVpExitReasonException:
-        case WHvRunVpExitReasonAlerted:
         default:
             error_report("WHPX: Unexpected VP exit code %d",
                          vcpu->exit_ctx.ExitReason);
@@ -1068,7 +1062,7 @@ int whpx_init_vcpu(CPUState *cpu)
         return -ENOMEM;
     }
 
-    hr = WHvEmulatorCreateEmulator(whpx_emu_callbacks, &vcpu->emulator);
+    hr = WHvEmulatorCreateEmulator(&whpx_emu_callbacks, &vcpu->emulator);
     if (FAILED(hr)) {
         error_report("WHPX: Failed to setup instruction completion support,"
                      " hr=%08lx", hr);
-- 
1.8.3.1

  parent reply	other threads:[~2018-03-06 13:20 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 13:18 [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06 Paolo Bonzini
2018-03-06 13:18 ` [Qemu-devel] [PULL 01/34] g364fb: fix DirtyBitmapSnapshot leak Paolo Bonzini
2018-03-06 13:18 ` [Qemu-devel] [PULL 02/34] Remove the deprecated -tdf option Paolo Bonzini
2018-03-06 13:18 ` [Qemu-devel] [PULL 03/34] scsi: Remove automatic creation of SCSI controllers with -drive if=scsi Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 04/34] cpus: properly inititalize CPU > 1 under single-threaded TCG Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 05/34] cpus: wait for CPU creation at central place Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 06/34] cpus: CPU threads are always created initially for one CPU only Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 07/34] Document --rtc-td-hack, --localtime and --startdate as deprecated Paolo Bonzini
2018-03-06 15:13   ` Thomas Huth
2018-03-06 15:20     ` Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 08/34] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 09/34] qmp: Add qom-list-properties to list QOM object properties Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 10/34] build-sys: fix -fsanitize=address check Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 11/34] lockable: workaround GCC link issue with ASAN Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 12/34] ahci-test: fix opts leak of skip tests Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 13/34] sdhci-test: fix leaks Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 14/34] chardev: fix leak in tcp_chr_telnet_init_io() Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 15/34] openpic_kvm: drop address_space_to_flatview call Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 16/34] memory: inline some performance-sensitive accessors Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 17/34] address_space_write: address_space_to_flatview needs RCU lock Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 18/34] address_space_read: " Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 19/34] address_space_access_valid: " Paolo Bonzini
2018-03-07 12:49   ` Cornelia Huck
2018-03-07 13:00     ` Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 20/34] address_space_map: " Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 21/34] address_space_rw: " Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 22/34] checkpatch: add a warning for basename/dirname Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 23/34] checkpatch: add check for `while` and `for` Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 24/34] Revert "build-sys: compile with -Og or -O1 when --enable-debug" Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 25/34] Fixing WHPX casing to match SDK Paolo Bonzini
2018-03-26 17:02   ` Eric Blake
2018-03-06 13:19 ` Paolo Bonzini [this message]
2018-03-06 13:19 ` [Qemu-devel] [PULL 27/34] Remove unnecessary WHPX __debugbreak(); Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 28/34] Fix WHPX additional lock acquisition Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 29/34] Fix WHPX typo in 'mmio' Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 30/34] Fix WHPX issue leaking tpr values Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 31/34] WHXP Removes the use of WHvGetExitContextSize Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 32/34] WHPX improve interrupt notification registration Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 33/34] balloon: Fix documentation of the --balloon parameter and deprecate it Paolo Bonzini
2018-03-06 13:19 ` [Qemu-devel] [PULL 34/34] use g_path_get_basename instead of basename Paolo Bonzini
2018-03-06 13:54 ` [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06 no-reply
2018-03-06 14:23 ` Peter Maydell
2018-03-07 11:39 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520342370-123606-27-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=juterry@microsoft.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).