From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etVXv-0003S6-Qy for qemu-devel@nongnu.org; Wed, 07 Mar 2018 04:39:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etVXs-0000Te-I1 for qemu-devel@nongnu.org; Wed, 07 Mar 2018 04:39:39 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42472 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etVXs-0000TL-D7 for qemu-devel@nongnu.org; Wed, 07 Mar 2018 04:39:36 -0500 From: Thomas Huth Date: Wed, 7 Mar 2018 10:39:28 +0100 Message-Id: <1520415568-19070-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH] hw/sparc/sun4m: Fix implicit creation of "-drive if=scsi" devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Mark Cave-Ayland Cc: Artyom Tarasenko , Paolo Bonzini The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the sun4m machines you now get: $ sparc-softmmu/qemu-system-sparc -boot d -cdrom x.iso qemu-system-sparc: -cdrom x.iso: machine type does not support if=scsi,bus=0,unit=2 Fix it by calling scsi_bus_legacy_handle_cmdline() after creating the corresponding SCSI controller. Reported-by: Mark Cave-Ayland Fixes: 1454509726719e0933c800fad00d6999752688ea Signed-off-by: Thomas Huth --- hw/sparc/sun4m.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 61eb424..0f5804b 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -324,6 +324,7 @@ static void *sparc32_dma_init(hwaddr dma_base, esp = ESP_STATE(object_resolve_path_component(OBJECT(espdma), "esp")); sysbus_mmio_map(SYS_BUS_DEVICE(esp), 0, esp_base); + scsi_bus_legacy_handle_cmdline(&esp->esp.bus); ledma = SPARC32_LEDMA_DEVICE(object_resolve_path_component( OBJECT(dma), "ledma")); -- 1.8.3.1