From: Wei Wang <wei.w.wang@intel.com>
To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com
Cc: pbonzini@redhat.com, wei.w.wang@intel.com,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com
Subject: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap
Date: Wed, 7 Mar 2018 20:34:23 +0800 [thread overview]
Message-ID: <1520426065-40265-3-git-send-email-wei.w.wang@intel.com> (raw)
In-Reply-To: <1520426065-40265-1-git-send-email-wei.w.wang@intel.com>
This patch adds an API to clear bits corresponding to guest free pages
from the dirty bitmap. Spilt the free page block if it crosses the QEMU
RAMBlock boundary.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
CC: Dr. David Alan Gilbert <dgilbert@redhat.com>
CC: Juan Quintela <quintela@redhat.com>
CC: Michael S. Tsirkin <mst@redhat.com>
---
include/migration/misc.h | 2 ++
migration/ram.c | 21 +++++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/include/migration/misc.h b/include/migration/misc.h
index 77fd4f5..fae1acf 100644
--- a/include/migration/misc.h
+++ b/include/migration/misc.h
@@ -14,11 +14,13 @@
#ifndef MIGRATION_MISC_H
#define MIGRATION_MISC_H
+#include "exec/cpu-common.h"
#include "qemu/notify.h"
/* migration/ram.c */
void ram_mig_init(void);
+void qemu_guest_free_page_hint(void *addr, size_t len);
/* migration/block.c */
diff --git a/migration/ram.c b/migration/ram.c
index 5e33e5c..e172798 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2189,6 +2189,27 @@ static int ram_init_all(RAMState **rsp)
return 0;
}
+void qemu_guest_free_page_hint(void *addr, size_t len)
+{
+ RAMBlock *block;
+ ram_addr_t offset;
+ size_t used_len, start, npages;
+
+ for (used_len = len; len > 0; len -= used_len) {
+ block = qemu_ram_block_from_host(addr, false, &offset);
+ if (unlikely(offset + len > block->used_length)) {
+ used_len = block->used_length - offset;
+ addr += used_len;
+ }
+
+ start = offset >> TARGET_PAGE_BITS;
+ npages = used_len >> TARGET_PAGE_BITS;
+ ram_state->migration_dirty_pages -=
+ bitmap_count_one_with_offset(block->bmap, start, npages);
+ bitmap_clear(block->bmap, start, npages);
+ }
+}
+
/*
* Each of ram_save_setup, ram_save_iterate and ram_save_complete has
* long-running RCU critical section. When rcu-reclaims in the code
--
1.8.3.1
next prev parent reply other threads:[~2018-03-07 12:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 12:34 [Qemu-devel] [PATCH v4 0/4] virtio-balloon: free page hint reporting support Wei Wang
2018-03-07 12:34 ` [Qemu-devel] [PATCH v4 1/4] bitmap: bitmap_count_one_with_offset Wei Wang
2018-03-14 16:20 ` Dr. David Alan Gilbert
2018-03-07 12:34 ` Wei Wang [this message]
2018-03-14 18:11 ` [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap Dr. David Alan Gilbert
2018-03-14 19:16 ` Michael S. Tsirkin
2018-03-14 19:42 ` Dr. David Alan Gilbert
2018-03-14 20:38 ` Michael S. Tsirkin
2018-03-15 11:10 ` Wei Wang
2018-03-15 10:52 ` Wei Wang
2018-03-15 13:50 ` Michael S. Tsirkin
2018-03-16 11:24 ` Wei Wang
2018-03-07 12:34 ` [Qemu-devel] [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-03-13 16:49 ` Michael S. Tsirkin
2018-03-14 2:43 ` [Qemu-devel] [virtio-dev] " Wei Wang
2018-03-14 2:53 ` Michael S. Tsirkin
2018-03-14 6:03 ` Wei Wang
2018-03-14 14:12 ` Michael S. Tsirkin
2018-03-15 1:15 ` Wei Wang
2018-03-15 2:47 ` Michael S. Tsirkin
2018-03-15 10:24 ` Wei Wang
2018-03-15 13:53 ` Michael S. Tsirkin
2018-03-14 18:44 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-03-07 12:34 ` [Qemu-devel] [PATCH v4 4/4] migration: use the free page hint feature from balloon Wei Wang
2018-03-13 16:35 ` Michael S. Tsirkin
2018-03-14 2:41 ` Wei Wang
2018-03-14 2:51 ` Michael S. Tsirkin
2018-03-14 6:50 ` Wei Wang
2018-03-14 14:45 ` Michael S. Tsirkin
2018-03-14 19:49 ` Dr. David Alan Gilbert
2018-03-16 11:20 ` Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520426065-40265-3-git-send-email-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=dgilbert@redhat.com \
--cc=liliang.opensource@gmail.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quan.xu0@gmail.com \
--cc=quintela@redhat.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).