From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: dgilbert@redhat.com, quintela@redhat.com, famz@redhat.com,
stefanha@redhat.com, jjherne@linux.vnet.ibm.com,
Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PATCH 5/5] migration/block: compare only read blocks against the rate limiter
Date: Thu, 8 Mar 2018 12:18:28 +0100 [thread overview]
Message-ID: <1520507908-16743-6-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1520507908-16743-1-git-send-email-pl@kamp.de>
only read_done blocks are in the queued to be flushed to the migration
stream. submitted blocks are still in flight.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
migration/block.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index ce939e2..4e950c2 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -773,8 +773,7 @@ static int block_save_iterate(QEMUFile *f, void *opaque)
/* control the rate of transfer */
blk_mig_lock();
- while ((block_mig_state.submitted +
- block_mig_state.read_done) * BLOCK_SIZE <
+ while (block_mig_state.read_done * BLOCK_SIZE <
qemu_file_get_rate_limit(f) &&
block_mig_state.submitted < MAX_PARALLEL_IO &&
(block_mig_state.submitted + block_mig_state.read_done) <
--
2.7.4
next prev parent reply other threads:[~2018-03-08 11:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 11:18 [Qemu-devel] [PATCH 0/5] block migration fixes Peter Lieven
2018-03-08 11:18 ` [Qemu-devel] [PATCH 1/5] migration: do not transfer ram during bulk storage migration Peter Lieven
2018-03-08 11:27 ` Juan Quintela
2018-03-08 11:18 ` [Qemu-devel] [PATCH 2/5] migration/block: reset dirty bitmap before read in bulk phase Peter Lieven
2018-03-08 11:39 ` Juan Quintela
2018-03-08 11:18 ` [Qemu-devel] [PATCH 3/5] migration/block: rename MAX_INFLIGHT_IO to MAX_IO_BUFFERS Peter Lieven
2018-03-08 11:31 ` Juan Quintela
2018-03-09 14:58 ` Dr. David Alan Gilbert
2018-03-09 19:57 ` Peter Lieven
2018-03-08 11:18 ` [Qemu-devel] [PATCH 4/5] migration/block: limit the number of parallel I/O requests Peter Lieven
2018-03-08 12:50 ` Juan Quintela
2018-03-08 13:30 ` Peter Lieven
2018-03-20 13:15 ` Peter Lieven
2018-03-20 18:02 ` Juan Quintela
2018-03-23 16:45 ` Dr. David Alan Gilbert
2018-03-08 11:18 ` Peter Lieven [this message]
2018-03-20 18:02 ` [Qemu-devel] [PATCH 5/5] migration/block: compare only read blocks against the rate limiter Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520507908-16743-6-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).