From: Lidong Chen <jemmy858585@gmail.com>
To: quintela@redhat.com, dgilbert@redhat.com
Cc: qemu-devel@nongnu.org, Lidong Chen <lidongchen@tencent.com>
Subject: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration
Date: Sat, 10 Mar 2018 22:32:58 +0800 [thread overview]
Message-ID: <1520692378-1835-1-git-send-email-lidongchen@tencent.com> (raw)
RDMA migration implement save_page function for QEMUFile, but
ram_control_save_page do not increase bytes_xfer. So when doing
RDMA migration, it will use whole bandwidth.
Signed-off-by: Lidong Chen <lidongchen@tencent.com>
---
migration/qemu-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 2ab2bf3..217609d 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -253,7 +253,7 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t block_offset,
if (f->hooks && f->hooks->save_page) {
int ret = f->hooks->save_page(f, f->opaque, block_offset,
offset, size, bytes_sent);
-
+ f->bytes_xfer += size;
if (ret != RAM_SAVE_CONTROL_DELAYED) {
if (bytes_sent && *bytes_sent > 0) {
qemu_update_position(f, *bytes_sent);
--
1.8.3.1
next reply other threads:[~2018-03-10 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 14:32 Lidong Chen [this message]
2018-03-13 12:55 ` [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration 858585 jemmy
2018-03-14 20:19 ` Dr. David Alan Gilbert
2018-03-15 5:33 ` 858585 jemmy
2018-03-19 12:10 ` 858585 jemmy
2018-03-20 18:19 ` Juan Quintela
2018-03-22 11:57 ` 858585 jemmy
2018-03-23 16:37 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520692378-1835-1-git-send-email-lidongchen@tencent.com \
--to=jemmy858585@gmail.com \
--cc=dgilbert@redhat.com \
--cc=lidongchen@tencent.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).