qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aishwarya Kadlag <aishwaryakadlag@gmail.com>
To: qemu-devel@nongnu.org
Cc: Aishwarya Kadlag <aishwaryakadlag@gmail.com>
Subject: [Qemu-devel] [PATCH V1]sm501: dead code removal
Date: Sun, 11 Mar 2018 22:10:14 +0530	[thread overview]
Message-ID: <1520786414-8806-1-git-send-email-aishwaryakadlag@gmail.com> (raw)

From: Aishwarya Kadlag <aishwaryakadlag@gmail.com>

Remove support for DEPTH != 32 values from hw/display/*_template.h 
files and other files that include them. Only DEPTH == 32 case is 
supported.

Signed-off-by: Aishwarya Kadlag <aishwaryakadlag@gmail.com>
---
hw/display/sw501_1.c              |   36 ------------------------------------ 
hw/display/sw501_template_1.h     |    4 +++- 
2 files changed, 3 insertions(+), 37 deletions(-)


diff -u sm501.c sm501_1.c > sm501.patch -s
--- sm501.c	2018-03-11 17:46:33.621452968 +0530
+++ sm501_1.c	2018-03-11 17:53:26.933445566 +0530
@@ -1358,22 +1358,6 @@
                                 int width, const uint8_t *palette,
                                 int c_x, int c_y);
 
-#define DEPTH 8
-#include "sm501_template.h"
-
-#define DEPTH 15
-#include "sm501_template.h"
-
-#define BGR_FORMAT
-#define DEPTH 15
-#include "sm501_template.h"
-
-#define DEPTH 16
-#include "sm501_template.h"
-
-#define BGR_FORMAT
-#define DEPTH 16
-#include "sm501_template.h"
 
 #define DEPTH 32
 #include "sm501_template.h"
@@ -1383,43 +1367,23 @@
 #include "sm501_template.h"
 
 static draw_line_func *draw_line8_funcs[] = {
-    draw_line8_8,
-    draw_line8_15,
-    draw_line8_16,
     draw_line8_32,
     draw_line8_32bgr,
-    draw_line8_15bgr,
-    draw_line8_16bgr,
 };
 
 static draw_line_func *draw_line16_funcs[] = {
-    draw_line16_8,
-    draw_line16_15,
-    draw_line16_16,
     draw_line16_32,
     draw_line16_32bgr,
-    draw_line16_15bgr,
-    draw_line16_16bgr,
 };
 
 static draw_line_func *draw_line32_funcs[] = {
-    draw_line32_8,
-    draw_line32_15,
-    draw_line32_16,
     draw_line32_32,
     draw_line32_32bgr,
-    draw_line32_15bgr,
-    draw_line32_16bgr,
 };
 
 static draw_hwc_line_func *draw_hwc_line_funcs[] = {
-    draw_hwc_line_8,
-    draw_hwc_line_15,
-    draw_hwc_line_16,
     draw_hwc_line_32,
     draw_hwc_line_32bgr,
-    draw_hwc_line_15bgr,
-    draw_hwc_line_16bgr,
 };
 
 static inline int get_depth_index(DisplaySurface *surface)



diff -u sm501_template.h sm501_template_1.h > sm501_template.patch -s
--- sm501_template.h    2018-03-11 17:25:36.816653718 +0530
+++ sm501_template_1.h  2018-03-11 17:25:16.828654076 +0530
@@ -22,13 +22,15 @@
  * THE SOFTWARE.
  */
 
+/*
 #if DEPTH == 8
 #define BPP 1
 #define PIXEL_TYPE uint8_t
 #elif DEPTH == 15 || DEPTH == 16
 #define BPP 2
 #define PIXEL_TYPE uint16_t
-#elif DEPTH == 32
+*/
+#if DEPTH == 32
 #define BPP 4
 #define PIXEL_TYPE uint32_t
 #else

             reply	other threads:[~2018-03-11 16:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11 16:40 Aishwarya Kadlag [this message]
2018-03-12  5:58 ` [Qemu-devel] [PATCH V1]sm501: dead code removal Thomas Huth
2018-03-12  7:05   ` Gerd Hoffmann
2018-03-12  7:35     ` Thomas Huth
2018-03-12 13:03     ` Peter Maydell
2018-03-12 17:58       ` Aishwarya Kadlag
2018-03-12  9:17   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520786414-8806-1-git-send-email-aishwaryakadlag@gmail.com \
    --to=aishwaryakadlag@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).