Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180313224719.4954-1-pbonzini@redhat.com
Subject: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180313224719.4954-1-pbonzini@redhat.com -> patchew/20180313224719.4954-1-pbonzini@redhat.com
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
20b2d41547 tcg: fix cpu_io_recompile
c46131d9ac replay: update documentation
ebbeee6c00 replay: save vmstate of the asynchronous events
6a1d180135 replay: don't process async events when warping the clock
d878031ce3 scripts/replay-dump.py: replay log dumper
fa49388d29 replay: avoid recursive call of checkpoints
8425f8a33b replay: check return values of fwrite
0c4cf018d7 replay: push replay_mutex_lock up the call tree
eedffef5df replay: don't destroy mutex at exit
a4649842a9 replay: make locking visible outside replay code
1570edbbd5 replay/replay-internal.c: track holding of replay_lock
e6d2f97e40 replay/replay.c: bump REPLAY_VERSION again
c0d71df05c replay: save prior value of the host clock
a7c57184b1 replay: added replay log format description
39eaf489fd replay: fix save/load vm for non-empty queue
980235a32e replay: fixed replay_enable_events
a846c03323 replay: fix processing async events
9f1d12928e cpu-exec: fix exception_index handling
1d6e886906 hw/i386/pc: Factor out the superio code
e24291717f hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO
1c75546a89 hw/alpha/dp264: Add the ISA DMA controller
8ccab0e5cc hw/isa/superio: Add the SMC FDC37C669 Super I/O
0638def1b5 MAINTAINERS: Split the Alpha TCG/machine section
fc68e597c6 MAINTAINERS: Add entries for the VT82C686B Super I/O
354da50497 hw/isa/vt82c686: Add the TYPE_VT82C686B_SUPERIO
66ca3f335d hw/isa/vt82c686: Rename vt82c686b_init() -> vt82c686b_isa_init()
112b337ef0 hw/mips/mips_fulong2e: Factor out vt82c686b_southbridge_init()
547f28856f hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c
048338438b hw/mips/malta: Code movement
898bc44d9f hw/isa/superio: Factor out the IDE code from pc87312.c
649c8ee02e hw/isa/superio: Add a keyboard/mouse controller (8042)
2f0ca2c71c hw/isa/superio: Factor out the floppy disc controller code from pc87312.c
84a2f1940f hw/isa/superio: Factor out the serial code from pc87312.c
744cf074a8 hw/isa/superio: Factor out the parallel code from pc87312.c
3ecb08902c hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO
3ad09fdf2c hw/isa/superio: Add a Super I/O template based on the PC87312 device
06a0adcfd8 hw/isa/pc87312: Use 'unsigned int' for the irq value
5479558c92 hw/isa/pc87312: Use uint16_t for the ISA I/O base address
1ca2ae2991 hw/isa/pc87312: Rename the device type as TYPE_PC87312_SUPERIO
25e755167f MAINTAINERS: Fix the PC87312 include path
f829b02d47 hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h
5e6c657232 hw/dma/i8257: Rename DMA_init() to i8257_dma_init()
922053d83d hw/isa: Move parallel_hds_isa_init() to hw/char/parallel-isa.c
18e14e69b7 membarrier: add --enable-membarrier
136b6f0343 membarrier: introduce qemu/sys_membarrier.h
7be9740f48 rcu: make memory barriers more explicit
9f4445960c docs: document atomic_load_acquire and atomic_store_release
f14149cb0a rcutorture: remove synchronize_rcu from readers
71d22958d8 hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices
5cd7037170 Polish the version strings containing the package version
0a13467c66 hw/i386: make IOMMUs configurable via default-configs/
4eec1790b5 scsi: support NDOB (no data-out buffer) for WRITE SAME commands
a5dd7aaf89 chardev: tcp: let TLS run on chardev context
0058402907 chardev: tcp: postpone async connection setup
189e98e5db chardev: use chardev's gcontext for async connect
6c6f38627f chardev: introduce chr_machine_done hook
498f244334 chardev: allow telnet gsource to switch gcontext
eee9ff412a chardev: update net listener gcontext
0fdbf8e1ce chardev: fix handling of EAGAIN for TCP chardev
a7967d2420 vl: export machine_init_done
1d2d7c57f1 checkpatch: Exempt long URLs
835403d319 hw: Do not include "sysemu/block-backend.h" if it is not necessary
b1502c478e build-sys: make help could have 'modules' target
b3b603a323 qemu-doc: Add the paragraph about the -no-frame deprecation again
90b5bafeb0 qemu-doc: update deprecation section to use -nic and -netdev hubport
94c73e33f5 scsi-disk.c: consider bl->max_transfer in INQUIRY emulation
9b1a0208b6 q35: change default NIC to e1000e
eb3ed01f15 net: allow using any PCI NICs in -net or -nic
91df7b715e qom: introduce object_class_get_list_sorted

=== OUTPUT BEGIN ===
Checking PATCH 1/69: qom: introduce object_class_get_list_sorted...
WARNING: line over 80 characters
#83: FILE: qom/object.c:903:
+    return g_slist_sort(object_class_get_list(implements_type, include_abstract),

total: 0 errors, 1 warnings, 173 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/69: net: allow using any PCI NICs in -net or -nic...
Checking PATCH 3/69: q35: change default NIC to e1000e...
Checking PATCH 4/69: scsi-disk.c: consider bl->max_transfer in INQUIRY emulation...
Checking PATCH 5/69: qemu-doc: update deprecation section to use -nic and -netdev hubport...
Checking PATCH 6/69: qemu-doc: Add the paragraph about the -no-frame deprecation again...
Checking PATCH 7/69: build-sys: make help could have 'modules' target...
Checking PATCH 8/69: hw: Do not include "sysemu/block-backend.h" if it is not necessary...
Checking PATCH 9/69: checkpatch: Exempt long URLs...
Checking PATCH 10/69: vl: export machine_init_done...
Checking PATCH 11/69: chardev: fix handling of EAGAIN for TCP chardev...
Checking PATCH 12/69: chardev: update net listener gcontext...
Checking PATCH 13/69: chardev: allow telnet gsource to switch gcontext...
Checking PATCH 14/69: chardev: introduce chr_machine_done hook...
Checking PATCH 15/69: chardev: use chardev's gcontext for async connect...
Checking PATCH 16/69: chardev: tcp: postpone async connection setup...
Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context...
Checking PATCH 18/69: scsi: support NDOB (no data-out buffer) for WRITE SAME commands...
WARNING: line over 80 characters
#59: FILE: tests/virtio-scsi-test.c:232:
+        virtio_scsi_do_command(vs, write_same_cdb_ndob, NULL, 0, NULL, 0, NULL));

total: 0 errors, 1 warnings, 34 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/69: hw/i386: make IOMMUs configurable via default-configs/...
Checking PATCH 20/69: Polish the version strings containing the package version...
Checking PATCH 21/69: hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices...
Checking PATCH 22/69: rcutorture: remove synchronize_rcu from readers...
Checking PATCH 23/69: docs: document atomic_load_acquire and atomic_store_release...
Checking PATCH 24/69: rcu: make memory barriers more explicit...
Checking PATCH 25/69: membarrier: introduce qemu/sys_membarrier.h...
ERROR: memory barrier without comment
#70: FILE: include/qemu/sys_membarrier.h:14:
+#define smp_mb_global()            smp_mb()

ERROR: memory barrier without comment
#71: FILE: include/qemu/sys_membarrier.h:15:
+#define smp_mb_placeholder()       smp_mb()

total: 2 errors, 0 warnings, 77 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 26/69: membarrier: add --enable-membarrier...
WARNING: line over 80 characters
#192: FILE: util/sys_membarrier.c:45:
+        error_report("This QEMU binary requires MEMBARRIER_CMD_SHARED support.");

total: 0 errors, 1 warnings, 154 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 27/69: hw/isa: Move parallel_hds_isa_init() to hw/char/parallel-isa.c...
Checking PATCH 28/69: hw/dma/i8257: Rename DMA_init() to i8257_dma_init()...
Checking PATCH 29/69: hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h...
Checking PATCH 30/69: MAINTAINERS: Fix the PC87312 include path...
Checking PATCH 31/69: hw/isa/pc87312: Rename the device type as TYPE_PC87312_SUPERIO...
Checking PATCH 32/69: hw/isa/pc87312: Use uint16_t for the ISA I/O base address...
Checking PATCH 33/69: hw/isa/pc87312: Use 'unsigned int' for the irq value...
Checking PATCH 34/69: hw/isa/superio: Add a Super I/O template based on the PC87312 device...
Checking PATCH 35/69: hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO...
Checking PATCH 36/69: hw/isa/superio: Factor out the parallel code from pc87312.c...
Checking PATCH 37/69: hw/isa/superio: Factor out the serial code from pc87312.c...
Checking PATCH 38/69: hw/isa/superio: Factor out the floppy disc controller code from pc87312.c...
Checking PATCH 39/69: hw/isa/superio: Add a keyboard/mouse controller (8042)...
Checking PATCH 40/69: hw/isa/superio: Factor out the IDE code from pc87312.c...
Checking PATCH 41/69: hw/mips/malta: Code movement...
Checking PATCH 42/69: hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c...
Checking PATCH 43/69: hw/mips/mips_fulong2e: Factor out vt82c686b_southbridge_init()...
Checking PATCH 44/69: hw/isa/vt82c686: Rename vt82c686b_init() -> vt82c686b_isa_init()...
Checking PATCH 45/69: hw/isa/vt82c686: Add the TYPE_VT82C686B_SUPERIO...
Checking PATCH 46/69: MAINTAINERS: Add entries for the VT82C686B Super I/O...
Checking PATCH 47/69: MAINTAINERS: Split the Alpha TCG/machine section...
Checking PATCH 48/69: hw/isa/superio: Add the SMC FDC37C669 Super I/O...
Checking PATCH 49/69: hw/alpha/dp264: Add the ISA DMA controller...
Checking PATCH 50/69: hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO...
Checking PATCH 51/69: hw/i386/pc: Factor out the superio code...
Checking PATCH 52/69: cpu-exec: fix exception_index handling...
Checking PATCH 53/69: replay: fix processing async events...
Checking PATCH 54/69: replay: fixed replay_enable_events...
Checking PATCH 55/69: replay: fix save/load vm for non-empty queue...
Checking PATCH 56/69: replay: added replay log format description...
Checking PATCH 57/69: replay: save prior value of the host clock...
Checking PATCH 58/69: replay/replay.c: bump REPLAY_VERSION again...
Checking PATCH 59/69: replay/replay-internal.c: track holding of replay_lock...
Checking PATCH 60/69: replay: make locking visible outside replay code...
Checking PATCH 61/69: replay: don't destroy mutex at exit...
Checking PATCH 62/69: replay: push replay_mutex_lock up the call tree...
Checking PATCH 63/69: replay: check return values of fwrite...
Checking PATCH 64/69: replay: avoid recursive call of checkpoints...
Checking PATCH 65/69: scripts/replay-dump.py: replay log dumper...
Checking PATCH 66/69: replay: don't process async events when warping the clock...
Checking PATCH 67/69: replay: save vmstate of the asynchronous events...
Checking PATCH 68/69: replay: update documentation...
Checking PATCH 69/69: tcg: fix cpu_io_recompile...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org